Review main Merged

86192[TASK] Use <details> and <summary> in DebuggerUtility::var_dump

Benjamin Franzke CR +2 V +2 Normal +108 −113 updated 09/27/24, 06:20

Commit message

Migrate var_dump HTML debug-output to use <details> + <summary> in
order to avoid checkbox-hacks for tree-collapsing and to allow the
usage of the following browser features:

 * "see above" links will auto-open nested trees
   (makes workarounds like #105013 unnecessary)
 * browser search can find entries and will
   uncollapse nested tree structures automatically

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Georg Ringer +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Georg Ringer +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 2

Files 5

Review log 2236

Show 611 earlier messages
  1. Benjamin Franzke uploaded patch set 1 09/19/24, 06:17

  2. core-ci voted on patch set 1 V +1 09/19/24, 06:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66163

  3. Benjamin Franzke uploaded patch set 2 V +1 09/19/24, 07:10

  4. Benjamin Franzke uploaded patch set 3 09/19/24, 07:17

  5. core-ci voted on patch set 2 V -1 09/19/24, 07:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66170

  6. core-ci voted on patch set 3 V -1 09/19/24, 07:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66172

  7. Benjamin Franzke commented on patch set 3 09/19/24, 08:09

    Note: symfony/var-dumper has been evaluated, but I'd like to keep using a no-js approach here, and symfony uses JavaScript for search, collapse and for deduplication (moves rendered content across the dom): https://github.com/symfony/symfony/blob/7.1/src/Symfony/Component/VarDumper/Dumper/HtmlDumper.php#L148-L623 Therefore I keep working on our "own" implementation…
  8. Benjamin Franzke uploaded patch set 4 V -1 09/19/24, 09:02

  9. core-ci voted on patch set 4 V -1 09/19/24, 09:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66189

  10. core-ci voted on patch set 4 V +1 09/19/24, 09:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66189

  11. Benjamin Franzke uploaded patch set 5 V +1 09/19/24, 12:28

  1. Benjamin Franzke updated the commit message in patch set 6 09/19/24, 12:29

  2. Benjamin Franzke updated the commit message in patch set 7 09/19/24, 12:39

  3. core-ci voted on patch set 5 V -1 09/19/24, 12:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66210

  4. core-ci voted on patch set 6 V -1 09/19/24, 12:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66212

  5. core-ci voted on patch set 7 V +1 09/19/24, 12:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66214

  6. Benjamin Franzke voted on patch set 7 V -1 09/20/24, 04:01

  7. Georg Ringer commented on patch set 7 09/20/24, 05:49

    I would love to see that in v12 as well
  8. Benjamin Franzke uploaded patch set 8 V +1 09/20/24, 09:00

  9. core-ci voted on patch set 8 V -1 09/20/24, 09:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66300

  10. Benjamin Franzke uploaded patch set 9 V -1 09/20/24, 11:53

  11. Benjamin Franzke uploaded patch set 10 09/20/24, 11:56

  12. core-ci voted on patch set 10 V +1 09/20/24, 12:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66323

  13. core-ci voted on patch set 9 V -1 09/20/24, 12:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66322

  14. Benjamin Franzke commented on patch set 10 09/20/24, 12:56

    Reply

    Thought about it, but v12 will soon go into priority bugfix mode, I don't think we should backport too much stuff any longer. This will be a nice gimmick in v13…
  15. Benjamin Franzke commented on patch set 10 09/20/24, 13:02

    DebuggerUtility.php:322

    Note: This codeblock tried to guess (we're in context `renderHeader()`), whether `renderContent` will render content. I've removed this logic here and rendered the id's in the calling method, in order to create proper `<summary>` tags – but only if content is rendered (that means: the object has properties that can be shown)
  16. Benjamin Franzke uploaded patch set 11 V +1 09/23/24, 09:54

  17. core-ci voted on patch set 11 V +1 09/23/24, 09:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66429

  18. Benjamin Franzke uploaded patch set 12 V +1 09/23/24, 10:08

  19. core-ci voted on patch set 12 V +1 09/23/24, 10:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66430

  20. Benjamin Franzke rebased onto patch set 13 V +1 09/24/24, 07:24

  21. core-ci voted on patch set 13 V +1 09/24/24, 07:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66479

  22. Andreas Kienast voted on patch set 13 CR +1 V +1 09/24/24, 07:44

  23. Georg Ringer voted on patch set 13 CR +1 V +1 09/27/24, 05:53

  24. Benjamin Franzke voted on patch set 13 CR +2 V +2 09/27/24, 06:19

  25. Benjamin Franzke merged patch set 14 09/27/24, 06:20