86192[TASK] Use <details> and <summary> in DebuggerUtility::var_dump
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Georg Ringer +1
- Andreas Kienast +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Georg Ringer +1
- Andreas Kienast +1
- core-ci +1 CI
Issues 2
Files 5
- Build/phpstan/phpstan-baseline.neon+0 −10
- typo3/sysext/extbase/Classes/Utility/DebuggerUtility.php1+105 −100
- typo3/sysext/extbase/Tests/Unit/Utility/Fixtures/Utf8OutputComplex.expected.html+1 −1
- typo3/sysext/extbase/Tests/Unit/Utility/Fixtures/Utf8OutputSimple.expected.html+1 −1
- typo3/sysext/extbase/Tests/Unit/Utility/DebuggerUtilityTest.php+1 −1
Review log 2236
Show 611 earlier messages
-
Benjamin Franzke uploaded patch set 1 09/19/24, 06:17
-
core-ci voted on patch set 1 V +1 09/19/24, 06:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66163
-
Benjamin Franzke uploaded patch set 2
V +109/19/24, 07:10 -
Benjamin Franzke uploaded patch set 3 09/19/24, 07:17
-
core-ci voted on patch set 2 V -1 09/19/24, 07:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66170
-
core-ci voted on patch set 3 V -1 09/19/24, 07:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66172
-
Benjamin Franzke commented on patch set 3 09/19/24, 08:09
Note: symfony/var-dumper has been evaluated, but I'd like to keep using a no-js approach here, and symfony uses JavaScript for search, collapse and for deduplication (moves rendered content across the dom): https://github.com/symfony/symfony/blob/7.1/src/Symfony/Component/VarDumper/Dumper/HtmlDumper.php#L148-L623 Therefore I keep working on our "own" implementation… -
Benjamin Franzke uploaded patch set 4
V -109/19/24, 09:02 -
core-ci voted on patch set 4 V -1 09/19/24, 09:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66189
-
core-ci voted on patch set 4 V +1 09/19/24, 09:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66189
-
Benjamin Franzke uploaded patch set 5
V +109/19/24, 12:28
-
Benjamin Franzke updated the commit message in patch set 6 09/19/24, 12:29
-
Benjamin Franzke updated the commit message in patch set 7 09/19/24, 12:39
-
core-ci voted on patch set 5 V -1 09/19/24, 12:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66210
-
core-ci voted on patch set 6 V -1 09/19/24, 12:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66212
-
core-ci voted on patch set 7 V +1 09/19/24, 12:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66214
-
Benjamin Franzke voted on patch set 7 V -1 09/20/24, 04:01
-
Georg Ringer commented on patch set 7 09/20/24, 05:49
I would love to see that in v12 as well -
Benjamin Franzke uploaded patch set 8
V +109/20/24, 09:00 -
core-ci voted on patch set 8 V -1 09/20/24, 09:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66300
-
Benjamin Franzke uploaded patch set 9
V -109/20/24, 11:53 -
Benjamin Franzke uploaded patch set 10 09/20/24, 11:56
-
core-ci voted on patch set 10 V +1 09/20/24, 12:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66323
-
core-ci voted on patch set 9 V -1 09/20/24, 12:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66322
-
Benjamin Franzke commented on patch set 10 09/20/24, 12:56
Reply
Thought about it, but v12 will soon go into priority bugfix mode, I don't think we should backport too much stuff any longer. This will be a nice gimmick in v13… -
Benjamin Franzke commented on patch set 10 09/20/24, 13:02
DebuggerUtility.php:322Note: This codeblock tried to guess (we're in context `renderHeader()`), whether `renderContent` will render content. I've removed this logic here and rendered the id's in the calling method, in order to create proper `<summary>` tags – but only if content is rendered (that means: the object has properties that can be shown) -
Benjamin Franzke uploaded patch set 11
V +109/23/24, 09:54 -
core-ci voted on patch set 11 V +1 09/23/24, 09:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66429
-
Benjamin Franzke uploaded patch set 12
V +109/23/24, 10:08 -
core-ci voted on patch set 12 V +1 09/23/24, 10:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66430
-
Benjamin Franzke rebased onto patch set 13
V +109/24/24, 07:24 -
core-ci voted on patch set 13 V +1 09/24/24, 07:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66479
-
Andreas Kienast voted on patch set 13 CR +1 V +1 09/24/24, 07:44
-
Georg Ringer voted on patch set 13 CR +1 V +1 09/27/24, 05:53
-
Benjamin Franzke voted on patch set 13 CR +2 V +2 09/27/24, 06:19
-
Benjamin Franzke merged patch set 14 09/27/24, 06:20