86193[BUGFIX] Properly respect multi-part altLabelField in DB Check
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Benni Mack +1
-
Verified V +2 Done
- Georg Ringer +2
- Benni Mack +1
- core-ci +1 CI
Issues 2
Files 1
Review log 1928
Show 3 earlier messages
-
Garvin Hicking uploaded patch set 1 09/19/24, 06:58
-
Garvin Hicking uploaded patch set 2 09/19/24, 07:05
-
Garvin Hicking commented on patch set 1 09/19/24, 07:07
There sadly is no central logic to get label_alt processing performed here. Applied similar logic as in TYPO3\CMS\Backend\Controller\EditDocumentController#699
-
core-ci voted on patch set 1 V -1 09/19/24, 07:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66164
-
core-ci voted on patch set 2 V -1 09/19/24, 07:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66165
-
Garvin Hicking uploaded patch set 3
V -109/20/24, 12:38 -
core-ci voted on patch set 3 V -1 09/20/24, 12:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66332
-
Garvin Hicking uploaded patch set 4
V -109/20/24, 12:52 -
core-ci voted on patch set 4 V +1 09/20/24, 12:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66333
-
Guido Schmechel commented on patch set 4 CR +1 10/03/24, 08:58
The code, even if duplicated, is okay for me. Cleaning up or using the planned TcaSchemaCollection classes would be possible later as a task for v13. -
Oliver Hader updated the commit message in patch set 5
CR +1V +110/18/24, 14:01 -
Oliver Hader rebased onto patch set 6 11/15/24, 09:13
-
core-ci voted on patch set 6 V +1 11/15/24, 09:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69465
-
Benni Mack updated the commit message in patch set 7
V +112/04/24, 11:46 -
core-ci voted on patch set 7 V +1 12/04/24, 11:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70585
-
Benni Mack commented on patch set 7 CR -1 02/10/25, 17:02
will fix this once with the Schema API in there... -
Benni Mack uploaded patch set 8
CR -1V +103/20/25, 20:08 -
core-ci voted on patch set 8 V +1 03/20/25, 20:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75908
-
Garvin Hicking marked it work in progress 03/20/25, 20:36
-
Garvin Hicking commented on patch set 8 03/20/25, 20:37
thx benni. Will wrap this up, similar treatment is probably needed around line ~2004. -
Garvin Hicking uploaded patch set 9
V +103/26/25, 12:29 -
Garvin Hicking marked it ready for review 03/26/25, 12:30
-
core-ci voted on patch set 9 V -1 03/26/25, 12:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76373
-
Garvin Hicking uploaded patch set 10
V -103/26/25, 12:54 -
core-ci voted on patch set 10 V +1 03/26/25, 13:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76376
-
Benni Mack voted on patch set 10 CR +1 V +1 03/26/25, 22:02
-
Georg Ringer voted on patch set 10 CR +2 V +2 03/27/25, 05:12
-
Georg Ringer merged patch set 11 03/27/25, 05:12