Review main Merged

86193[BUGFIX] Properly respect multi-part altLabelField in DB Check

Garvin Hicking CR +2 V +2 Normal +81 −28 updated 03/27/25, 05:12

Commit message

In case TCA definitions set a 'label_alt' value with multiple
fields (like `tt_content` with `subheader,bodytext`) then the
DB Check will not be able to resolve value selections for
query parts (e.g. the select dropdown to allow picking tt_content
records for the parts of the query).

Additional problems came up when a relation like `CType` is
defined as 'label_alt' and not properly resolved.

This patch also addresses some side-effects of the TCA Schema
API integration of #106156:

- Repeated record row header labels
- Problems resolving "uid" when selected (not part of Schema API
  `->getField()`)
- Wrong `$outString` placement leading to unneeded linebreaks
- Combined two identical occurrences of code into a helper method
  `evaluateRelationDisplayWithLabels`
- Missing type-safety check for "labels_noprefix" option

See forge ticket for steps to reproduce.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 1928

Show 3 earlier messages
  1. Garvin Hicking uploaded patch set 1 09/19/24, 06:58

  2. Garvin Hicking uploaded patch set 2 09/19/24, 07:05

  3. Garvin Hicking commented on patch set 1 09/19/24, 07:07

    There sadly is no central logic to get label_alt processing performed here. Applied similar logic as in TYPO3\CMS\Backend\Controller\EditDocumentController#699
  1. core-ci voted on patch set 1 V -1 09/19/24, 07:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66164

  2. core-ci voted on patch set 2 V -1 09/19/24, 07:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66165

  3. Garvin Hicking uploaded patch set 3 V -1 09/20/24, 12:38

  4. core-ci voted on patch set 3 V -1 09/20/24, 12:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66332

  5. Garvin Hicking uploaded patch set 4 V -1 09/20/24, 12:52

  6. core-ci voted on patch set 4 V +1 09/20/24, 12:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66333

  7. Guido Schmechel commented on patch set 4 CR +1 10/03/24, 08:58

    The code, even if duplicated, is okay for me. Cleaning up or using the planned TcaSchemaCollection classes would be possible later as a task for v13.
  8. Oliver Hader updated the commit message in patch set 5 CR +1 V +1 10/18/24, 14:01

  9. Oliver Hader rebased onto patch set 6 11/15/24, 09:13

  10. core-ci voted on patch set 6 V +1 11/15/24, 09:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69465

  11. Benni Mack updated the commit message in patch set 7 V +1 12/04/24, 11:46

  12. core-ci voted on patch set 7 V +1 12/04/24, 11:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70585

  13. Benni Mack commented on patch set 7 CR -1 02/10/25, 17:02

    will fix this once with the Schema API in there...
  14. Benni Mack uploaded patch set 8 CR -1 V +1 03/20/25, 20:08

  15. core-ci voted on patch set 8 V +1 03/20/25, 20:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75908

  16. Garvin Hicking marked it work in progress 03/20/25, 20:36

  17. Garvin Hicking commented on patch set 8 03/20/25, 20:37

    thx benni. Will wrap this up, similar treatment is probably needed around line ~2004.
  18. Garvin Hicking uploaded patch set 9 V +1 03/26/25, 12:29

  19. Garvin Hicking marked it ready for review 03/26/25, 12:30

  20. core-ci voted on patch set 9 V -1 03/26/25, 12:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76373

  21. Garvin Hicking uploaded patch set 10 V -1 03/26/25, 12:54

  22. core-ci voted on patch set 10 V +1 03/26/25, 13:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76376

  23. Benni Mack voted on patch set 10 CR +1 V +1 03/26/25, 22:02

  24. Georg Ringer voted on patch set 10 CR +2 V +2 03/27/25, 05:12

  25. Georg Ringer merged patch set 11 03/27/25, 05:12