86194[BUGFIX] Use proper FileReference for imageLinkWrap
Commit message
Review
-
Code review CR +2 Done
- Garvin Hicking +2
- Franz Holzinger +1
- Benni Mack +1
-
Verified V +2 Done
- Garvin Hicking +2
- Franz Holzinger +1
- Benni Mack +1
Issues 1
Files 1
Review log 1516
-
Garvin Hicking uploaded patch set 1 09/19/24, 07:43
-
Mathias Brodala commented on patch set 1 09/19/24, 07:46
-
core-ci voted on patch set 1 V +1 09/19/24, 07:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66175
-
Garvin Hicking commented on patch set 1 09/19/24, 08:07
ContentObjectRenderer.php:903ReplyUnsure. There are two $file->getUid() calls later on, and I guess these need to be made on the FileReference object and not the originalFile one?! -
Mathias Brodala commented on patch set 1 09/19/24, 08:12
ContentObjectRenderer.php:903ReplyRight, the showpic thingy needs to refer to the processed file. -
Mathias Brodala voted on patch set 1 CR +1 09/19/24, 08:36
-
Franz Holzinger voted on patch set 1 V +1 09/21/24, 19:29
-
Benni Mack updated the commit message in patch set 2
CR +1V +110/18/24, 13:54 -
Benni Mack voted on patch set 2 CR +1 V +1 10/18/24, 13:54
-
Garvin Hicking updated the commit message in patch set 3
CR +1V +110/18/24, 16:56 -
Garvin Hicking rebased onto patch set 4 10/18/24, 16:57
-
Franz Holzinger voted on patch set 4 CR +1 10/22/24, 16:23
-
Franz Holzinger voted on patch set 4 V +1 10/22/24, 16:24
-
Benni Mack voted on patch set 4 CR +1 V +1 10/23/24, 15:40
-
Garvin Hicking voted on patch set 4 CR +2 V +2 10/23/24, 16:44
-
Garvin Hicking merged patch set 5 10/23/24, 17:20
ContentObjectRenderer.php:903