Review main Merged

86195[BUGFIX] Correct deprecation messages in TSFE for cache tags methods

Chris Müller CR +2 V +2 Easy +2 −2 updated 09/19/24, 14:22

Commit message

The PSR-7 request attribute is named "frontend.cache.collector"
(like also visible in the code below the triggered error).

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Sascha Nowak +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Sascha Nowak +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 1014

  1. Chris Müller uploaded patch set 1 09/19/24, 08:20

  2. Chris Müller marked it work in progress 09/19/24, 08:20

  3. Chris Müller uploaded patch set 2 09/19/24, 08:22

  4. Chris Müller marked it ready for review 09/19/24, 08:22

  5. core-ci voted on patch set 2 V +1 09/19/24, 08:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66184

  6. core-ci voted on patch set 1 V +1 09/19/24, 08:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66183

  7. Chris Müller updated the commit message in patch set 3 V +1 09/19/24, 09:02

  8. core-ci voted on patch set 3 V -1 09/19/24, 09:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66188

  9. Chris Müller updated the commit message in patch set 4 09/19/24, 09:36

    Copied Votes: * Verified-1 (copy condition: "**changekind:NO_CHANGE**")
  10. core-ci voted on patch set 4 V +1 09/19/24, 09:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66190

  11. Christian Kuhn voted on patch set 4 CR +1 V +1 09/19/24, 14:03

  12. Sascha Nowak voted on patch set 4 CR +1 V +1 09/19/24, 14:04

  13. Christian Kuhn voted on patch set 4 CR +2 V +2 09/19/24, 14:21

  14. Christian Kuhn merged patch set 5 09/19/24, 14:22