86196[TASK] Relocate hidden elements toggle to docheader in pagelayout
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Andreas Kienast +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Andreas Kienast +1
- core-ci +1 CI
Issues 1
Files 9
- Build/Sources/Sass/component/_dropdown.scss+25 −0
- Build/Sources/Sass/component/_root.scss+3 −0
- Build/Sources/TypeScript/backend/page-actions.ts+9 −7
- typo3/sysext/backend/Classes/Controller/PageLayoutController.php+28 −4
- typo3/sysext/backend/Classes/Template/Components/Buttons/DropDown/AbstractDropDownItem.php+11 −1
- typo3/sysext/backend/Classes/Template/Components/Buttons/DropDown/DropDownToggle.php+2 −9
- typo3/sysext/backend/Resources/Private/Templates/PageLayout/PageModule.html+0 −16
- typo3/sysext/backend/Resources/Public/Css/backend.css+4 −1
- typo3/sysext/backend/Resources/Public/JavaScript/page-actions.js+1 −1
Review log 914
-
Benjamin Kott uploaded patch set 1 09/19/24, 10:44
-
core-ci voted on patch set 1 V -1 09/19/24, 11:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66199
-
Andreas Kienast uploaded patch set 2
V -109/19/24, 11:02 -
core-ci voted on patch set 2 V -1 09/19/24, 11:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66201
-
Benjamin Kott uploaded patch set 3
V -109/19/24, 11:24 -
core-ci voted on patch set 3 V -1 09/19/24, 11:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66203
-
Andreas Kienast uploaded patch set 4
V -109/19/24, 12:25 -
Andreas Kienast uploaded patch set 5 09/19/24, 12:43
-
core-ci voted on patch set 4 V -1 09/19/24, 12:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66209
-
core-ci voted on patch set 5 V +1 09/19/24, 13:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66218
-
Andreas Kienast voted on patch set 5 CR +1 V +1 09/19/24, 13:20
-
Benjamin Franzke commented on patch set 5 CR -1 09/19/24, 14:43
Can we have another icon instead of `actions-eye`? It feels awkward to see the action icon as a descriptive icon for the label. (And in constrast to the filelist, this menu doesn't look very good, because the icons in filelist view are rectangular, while both the checkmark and actions-eye are quite round, and because this label is quite long. Also, since there are often no visual differences after toggling hidden elements visibility, it feels like there should be some notification (most of the time there is nothing happening in general, when the hidden elements are outside the visible viewport). -
Benjamin Franzke commented on patch set 5 CR +2 V +2 09/23/24, 12:06
Reply
Can be discussed later. -
Benjamin Franzke merged patch set 6 09/23/24, 12:07