Review main Merged

86196[TASK] Relocate hidden elements toggle to docheader in pagelayout

Benjamin Kott CR +2 V +2 Normal +83 −39 updated 09/23/24, 12:07

Commit message

This change aligns with the ongoing effort to centralize view-related
settings in the docheader. The hidden elements toggle in the page
layout view has been moved to the docheader for a more consistent
UI. The toggle is now always visible, even when no hidden elements
are present on the page.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 9

Review log 914

  1. Benjamin Kott uploaded patch set 1 09/19/24, 10:44

  2. core-ci voted on patch set 1 V -1 09/19/24, 11:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66199

  3. Andreas Kienast uploaded patch set 2 V -1 09/19/24, 11:02

  4. core-ci voted on patch set 2 V -1 09/19/24, 11:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66201

  5. Benjamin Kott uploaded patch set 3 V -1 09/19/24, 11:24

  6. core-ci voted on patch set 3 V -1 09/19/24, 11:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66203

  7. Andreas Kienast uploaded patch set 4 V -1 09/19/24, 12:25

  8. Andreas Kienast uploaded patch set 5 09/19/24, 12:43

  9. core-ci voted on patch set 4 V -1 09/19/24, 12:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66209

  10. core-ci voted on patch set 5 V +1 09/19/24, 13:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66218

  11. Andreas Kienast voted on patch set 5 CR +1 V +1 09/19/24, 13:20

  12. Benjamin Franzke commented on patch set 5 CR -1 09/19/24, 14:43

    Can we have another icon instead of `actions-eye`? It feels awkward to see the action icon as a descriptive icon for the label. (And in constrast to the filelist, this menu doesn't look very good, because the icons in filelist view are rectangular, while both the checkmark and actions-eye are quite round, and because this label is quite long. Also, since there are often no visual differences after toggling hidden elements visibility, it feels like there should be some notification (most of the time there is nothing happening in general, when the hidden elements are outside the visible viewport).
  13. Benjamin Franzke commented on patch set 5 CR +2 V +2 09/23/24, 12:06

    Reply

    Can be discussed later.
  14. Benjamin Franzke merged patch set 6 09/23/24, 12:07