Review main Merged

86200[TASK] Update to CKEditor v43.1

Andreas Nedbal CR +2 V +2 Expert +765 −678 updated 09/20/24, 12:20

Commit message

Executed commands:
   npm --prefix overrides/ckeditor5 version 43.1.0
   npm install --save ./overrides/ckeditor5 $(
     grep @ckeditor/ package.json | \
     grep -v @ckeditor/ckeditor5-dev-utils | \
     grep -v @ckeditor/ckeditor5-inspector | \
     sed 's/^[^"]*"\([^"]*\)".*/\1@43.1.0/' \
   )
   npm run build

Review

  • Code review CR +2 Done
    • Andreas Nedbal +2
    • Benjamin Franzke +1
    • Garvin Hicking +1
  • Verified V +2 Done
    • Andreas Nedbal +2
    • Benjamin Franzke +1
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 80

Show 60 more files

Review log 911

  1. Andreas Nedbal uploaded patch set 1 09/19/24, 12:42

  2. Benjamin Franzke commented on patch set 1 09/19/24, 12:47

    ckeditor.js:76

    Do you know what `marked` is used for and why this is needed? If this is really needed, then `marked` is something that we'd probably ship as an external import (placed in Contrib/marked.js) – so we can use it in core as well, without shipping duplicate libraries. -1 for now, as a I need to check that
  3. Benjamin Franzke voted on patch set 1 CR -1 09/19/24, 12:47

  4. Andreas Nedbal uploaded patch set 2 CR -1 09/19/24, 12:55

  5. Andreas Nedbal commented on patch set 1 09/19/24, 12:57

    ckeditor.js:76 Reply

    Leftover from a local update without the overrides package. Those are dependencies for a new plugin that CKEditor ships with (and we don't include in the override), so when I initially updated manually I had to skip these Markdown-related dependencies. Re-running the update without those lines worked fine and didn't require skipping, so this is solved now.
  6. core-ci voted on patch set 1 V +1 09/19/24, 13:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66217

  7. core-ci voted on patch set 2 V +1 09/19/24, 13:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66219

  8. Benjamin Franzke commented on patch set 2 CR +1 V +1 09/19/24, 14:46

    ckeditor.js:76 Reply

    Alright.
  9. Garvin Hicking commented on patch set 2 CR +1 V +1 09/20/24, 11:37

    Reviewing CKEditor changelogs is a pain, you never know what might have an impact and whatnot. Anyhow - from what I figure the changes should not affect "us" negatively. config.htmlEmbed.sanitizeHtml was my main worry, but it seems we do not utilize this at all with the TYPO3 surroundings.
  10. Andreas Nedbal voted on patch set 2 CR +2 V +2 09/20/24, 12:20

  11. Andreas Nedbal merged patch set 3 09/20/24, 12:20