Review main Merged

86201[TASK] Improve extbase SourceInterface handling

Christian Kuhn CR +2 V +2 Hard +75 −215 updated 09/20/24, 14:33

Commit message

We stumbled upon the fishy SourceInterface when working
on #104990: This is an empty interface, extended by
SelectorInterface and JoinInterface (violating interface
composition over inheritance), and implemented by
Join and Selector respectively.

The patch changes SelectorInterface and JoinInterface to
no longer extend SourceInterface, and implements both
in Join / Selector.

Looking at consumers, various types are added to add
more native PHP type support to the extbase QOM layer.
This substitutes some type commments, which turned out
to be partially wrong: Most notably selector() of
QueryObjectModelFactory, which is called with
$nodeTypeName being null.

This codebase should receive a bigger overhaul, and
it helps to have more types we can rely on when doing so.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 13

Review log 812

  1. Christian Kuhn uploaded patch set 1 09/19/24, 13:57

  2. core-ci voted on patch set 1 V +1 09/19/24, 14:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66220

  3. Christian Kuhn uploaded patch set 2 V +1 09/19/24, 14:26

  4. core-ci voted on patch set 2 V -1 09/19/24, 14:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66222

  5. Christian Kuhn uploaded patch set 3 V -1 09/19/24, 18:53

  6. core-ci voted on patch set 3 V +1 09/19/24, 19:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66242

  7. Christian Kuhn updated the commit message in patch set 4 V +1 09/19/24, 19:49

  8. core-ci voted on patch set 4 V +1 09/19/24, 19:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66249

  9. Stefan Bürk voted on patch set 4 CR +1 09/20/24, 10:26

  10. Stefan Bürk voted on patch set 4 V +1 09/20/24, 10:36

  11. Anja Leichsenring voted on patch set 4 CR +2 V +2 09/20/24, 14:33

  12. Anja Leichsenring merged patch set 5 09/20/24, 14:33