Review main Merged

86205[DOCS] Move changelogs relevant for 12.4.x to matching directory

Garvin Hicking CR +2 V +2 Easy +1 −1 updated 09/24/24, 07:53

Commit message

Two changelog ReST files were initially placed in the 13.x
structure, but were backported to 12.x.

This patch moves one of the ReST files to the `12.4.x` directory,
also to raise awareness for the next 12.4.x release so
that people who might have missed these two changelogs
can catch up. The other is irrelevant for 12.4.x and
thus removed in the backport (not in main).

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Guido Schmechel +1
    • Anja Leichsenring +1
    • Lina Wolf +1
    • Benni Mack +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Guido Schmechel +1
    • Anja Leichsenring +1
    • Lina Wolf +1
    • core-ci +1 CI

Issues 3

Files 1

Review log 1215

  1. Garvin Hicking uploaded patch set 1 09/19/24, 19:43

  2. core-ci voted on patch set 1 V +1 09/19/24, 19:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66247

  3. Stefan Froemken commented on patch set 1 09/19/24, 20:35

    Why does the new file has that additional timestamp in its filename?
  4. Garvin Hicking commented on patch set 1 09/19/24, 20:57

    Reply

    The other way. I removed the timestamp, because it's uncommon :)
  5. Christian Kuhn commented on patch set 1 CR -1 09/19/24, 21:50

    Deprecation-104108-TableDependantDefinitionOfColumnsOnly.rst:6

    this file should be removed from v12 altogether: while the v13 patch adds an active trigger_error in EditDocumentController, this is left out in the v12 version of the patch and is only an annotated deprecation, not an active one.
  6. Garvin Hicking uploaded patch set 2 CR -1 V +1 09/20/24, 11:15

  7. Garvin Hicking commented on patch set 2 09/20/24, 11:19

    Deprecation-104108-TableDependantDefinitionOfColumnsOnly.rst:6 Reply

    I've cherry-picked this patch to 12.4 and removed the file there. In the "main" variant, I only move one file. good?
  8. core-ci voted on patch set 2 V -1 09/20/24, 11:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66317

  9. core-ci voted on patch set 2 V +1 09/20/24, 12:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66317

  10. Guido Schmechel voted on patch set 2 CR +1 V +1 09/22/24, 09:41

  11. Lina Wolf voted on patch set 2 CR +1 V +1 09/22/24, 14:33

  12. Anja Leichsenring voted on patch set 2 CR +1 V +1 09/24/24, 06:39

  13. Benni Mack voted on patch set 2 CR +1 09/24/24, 06:46

  14. Garvin Hicking voted on patch set 2 CR +2 V +2 09/24/24, 07:52

  15. Garvin Hicking merged patch set 3 09/24/24, 07:53