Review main Merged

86210[TASK] More DI in ext:backend Authentication/PasswordReset

Christian Kuhn CR +2 V +2 Hard +153 −109 updated 09/20/24, 14:01

Commit message

Get most dependencies right on yet another class.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Martin Adler +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Martin Adler +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 811

  1. Christian Kuhn uploaded patch set 1 09/19/24, 23:39

  2. core-ci voted on patch set 1 V -1 09/19/24, 23:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66269

  3. Christian Kuhn uploaded patch set 2 V -1 09/20/24, 11:06

  4. Christian Kuhn updated the commit message in patch set 3 09/20/24, 11:09

  5. core-ci voted on patch set 3 V +1 09/20/24, 11:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66316

  6. core-ci voted on patch set 2 V +1 09/20/24, 11:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66314

  7. Martin Adler commented on patch set 3 CR +1 V +1 09/20/24, 12:25

    PasswordReset.php:70

    @lolli@schwarzbu.ch Minor thing .. as for aesthestics and readability, I'd suggest to sort alphabetically here: public function __construct( private ConnectionPool $connectionPool, private EventDispatcherInterface $eventDispatcher, private HashService $hashService, private LoggerInterface $logger, private MailerInterface $mailer, private PasswordHashFactory $passwordHashFactory, private Random $random, private SessionManager $sessionManager, private UriBuilder $uriBuilder, ) {}
  8. Christian Kuhn commented on patch set 3 09/20/24, 13:45

    PasswordReset.php:70 Reply

    We're doing this nowhere. I tend to put important/global stuff first, and there is no rule regarding ordering. Let's not start with this now.
  9. Stefan Bürk voted on patch set 3 CR +1 V +1 09/20/24, 13:53

  10. Christian Kuhn voted on patch set 3 CR +2 V +2 09/20/24, 14:01

  11. Christian Kuhn merged patch set 4 09/20/24, 14:01