Review main Merged

86211[TASK] Add context-awareness to diff component

Benjamin Kott CR +2 V +2 Normal +44 −49 updated 09/23/24, 07:04

Commit message

Updated the diff component to dynamically adjust to light and dark color
schemes, improving its adaptability and usability when displaying version
changes and differences.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 79

  1. Benjamin Kott uploaded patch set 1 09/20/24, 06:44

  2. core-ci voted on patch set 1 V +1 09/20/24, 06:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66289

  3. Andreas Kienast commented on patch set 1 09/20/24, 07:38

    _diff.scss:25

    These variables can be removed, if I see that correctly.
  4. Benjamin Kott uploaded patch set 2 V +1 09/20/24, 08:18

  5. Benjamin Kott commented on patch set 2 09/20/24, 08:19

    _diff.scss:25 Reply

    Done
  6. core-ci voted on patch set 2 V +1 09/20/24, 08:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66297

  7. Andreas Kienast voted on patch set 2 CR +1 V +1 09/20/24, 08:31

  8. Benjamin Franzke commented on patch set 2 CR +2 V +2 09/23/24, 07:04

    _diff.scss:74

    the surface container color doesn't work properly on inline elements, as the background is only applied to the text itself, not the line-height based container. `display: inline-block` would improve that, but breaks automatic line breaks… So I'm ok with this, given we tune colors later on anyway.
  9. Benjamin Franzke merged patch set 3 09/23/24, 07:04