86211[TASK] Add context-awareness to diff component
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Andreas Kienast +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Andreas Kienast +1
- core-ci +1 CI
Issues 1
Files 5
Review log 79
-
Benjamin Kott uploaded patch set 1 09/20/24, 06:44
-
core-ci voted on patch set 1 V +1 09/20/24, 06:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66289
-
Andreas Kienast commented on patch set 1 09/20/24, 07:38
-
Benjamin Kott uploaded patch set 2
V +109/20/24, 08:18 -
Benjamin Kott commented on patch set 2 09/20/24, 08:19
_diff.scss:25ReplyDone -
core-ci voted on patch set 2 V +1 09/20/24, 08:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66297
-
Andreas Kienast voted on patch set 2 CR +1 V +1 09/20/24, 08:31
-
Benjamin Franzke commented on patch set 2 CR +2 V +2 09/23/24, 07:04
_diff.scss:74the surface container color doesn't work properly on inline elements, as the background is only applied to the text itself, not the line-height based container. `display: inline-block` would improve that, but breaks automatic line breaks… So I'm ok with this, given we tune colors later on anyway. -
Benjamin Franzke merged patch set 3 09/23/24, 07:04
_diff.scss:25