Review main Merged

86214[TASK] Revert "[TASK] Improve debug output of PAGEVIEW"

Benjamin Franzke CR +2 V +2 Easy +1 −1 updated 11/11/24, 16:27

Commit message

This reverts commit de1d92aab19b5c34105374090d89db8548a7e592.

Reason for revert:
The adressed debugging usability issue (the nested evaluation of the
language object in scope of the site object in output of <f:debug>)
has been adressed by #105043.

That means we can go back to logical ordering that reflects the
order how these variables have been resolved by the middleware
stack and are therefore logically tangible:

 * The `site` is resolved based on a request
 * The `language` is resolved based on a site of the request
 * The `page` is resolved based on the `site` and `language`

This logical structure helps developers to get a comprehensible overview
of variables instead of having to grasp a random ordered pile of
variables.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Stefan Bürk +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Stefan Bürk +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1821

  1. Benjamin Franzke uploaded patch set 1 09/19/24, 12:39

  2. Benjamin Franzke rebased onto patch set 2 09/19/24, 12:39

  3. Benjamin Franzke commented on patch set 2 CR -2 09/19/24, 12:40

    -2 until > 86192: [TASK] Use <details> and <summary> in DebuggerUtility::var_dump | https://review.typo3.org/c/Packages/TYPO3.CMS/+/86192 is merged
  4. Benjamin Franzke updated the commit message in patch set 3 09/19/24, 12:41

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  5. core-ci voted on patch set 3 V +1 09/19/24, 13:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66216

  6. Benjamin Franzke rebased onto patch set 4 V +1 09/20/24, 13:04

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  7. core-ci voted on patch set 4 V +1 09/20/24, 13:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66335

  8. Benjamin Franzke commented on patch set 4 CR 0 09/27/24, 12:21

    Reply

    done
  9. Benjamin Kott commented on patch set 4 CR -1 09/27/24, 13:42

    This patch is reasoned to be helpful as much as it is helpful to press the horn in a traffic jam
  10. Benjamin Franzke commented on patch set 4 09/27/24, 13:43

    Reply

    🖕🖕🖕
  11. Christian Kuhn commented on patch set 4 10/21/24, 09:53

    still needed?
  12. Christian Kuhn commented on patch set 4 10/26/24, 15:27

    hey. i hope its ok to go ahead here to abandon this one: i think the change isn't crucially important and we can easily live without it. please resurrect if you think we should still do it.
  13. Christian Kuhn abandoned the change 10/26/24, 15:27

  14. Benjamin Franzke restored the change 10/28/24, 06:40

  15. Benjamin Franzke uploaded patch set 5 CR -1 V +1 10/28/24, 06:54

  16. Benjamin Franzke commented on patch set 5 10/28/24, 06:54

    Reply

    I have further elaborated the commit message in the hope of making the reasons comprehensible.

    Reply

    yes
  17. core-ci voted on patch set 5 V +1 10/28/24, 06:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68708

  18. Christian Kuhn commented on patch set 5 CR +1 V +1 11/11/24, 14:53

    ok. fine with me.
  19. Stefan Bürk voted on patch set 5 CR +1 V +1 11/11/24, 16:08

  20. Benjamin Franzke voted on patch set 5 CR +2 V +2 11/11/24, 16:17

  21. Benjamin Franzke merged patch set 6 11/11/24, 16:27