86214[TASK] Revert "[TASK] Improve debug output of PAGEVIEW"
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Stefan Bürk +1
- Christian Kuhn +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Stefan Bürk +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1821
-
Benjamin Franzke uploaded patch set 1 09/19/24, 12:39
-
Benjamin Franzke rebased onto patch set 2 09/19/24, 12:39
-
Benjamin Franzke commented on patch set 2 CR -2 09/19/24, 12:40
-2 until > 86192: [TASK] Use <details> and <summary> in DebuggerUtility::var_dump | https://review.typo3.org/c/Packages/TYPO3.CMS/+/86192 is merged -
Benjamin Franzke updated the commit message in patch set 3 09/19/24, 12:41
Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
core-ci voted on patch set 3 V +1 09/19/24, 13:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66216
-
Benjamin Franzke rebased onto patch set 4
V +109/20/24, 13:04Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
core-ci voted on patch set 4 V +1 09/20/24, 13:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66335
-
Benjamin Franzke commented on patch set 4 CR 0 09/27/24, 12:21
Reply
done -
Benjamin Kott commented on patch set 4 CR -1 09/27/24, 13:42
This patch is reasoned to be helpful as much as it is helpful to press the horn in a traffic jam -
Benjamin Franzke commented on patch set 4 09/27/24, 13:43
Reply
🖕🖕🖕 -
Christian Kuhn commented on patch set 4 10/21/24, 09:53
still needed? -
Christian Kuhn commented on patch set 4 10/26/24, 15:27
hey. i hope its ok to go ahead here to abandon this one: i think the change isn't crucially important and we can easily live without it. please resurrect if you think we should still do it. -
Christian Kuhn abandoned the change 10/26/24, 15:27
-
Benjamin Franzke restored the change 10/28/24, 06:40
-
Benjamin Franzke uploaded patch set 5
CR -1V +110/28/24, 06:54 -
Benjamin Franzke commented on patch set 5 10/28/24, 06:54
Reply
I have further elaborated the commit message in the hope of making the reasons comprehensible.Reply
yes -
core-ci voted on patch set 5 V +1 10/28/24, 06:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68708
-
Christian Kuhn commented on patch set 5 CR +1 V +1 11/11/24, 14:53
ok. fine with me. -
Stefan Bürk voted on patch set 5 CR +1 V +1 11/11/24, 16:08
-
Benjamin Franzke voted on patch set 5 CR +2 V +2 11/11/24, 16:17
-
Benjamin Franzke merged patch set 6 11/11/24, 16:27