Review 12.4 Merged

86217[BUGFIX] Add missing itemsProcFunc record context

Garvin Hicking CR +2 V +2 Normal +102 −19 updated 09/20/24, 06:27

Commit message

Since #100855, itemsProcFunc's are resolved on
processing field values by corresponding BackendUtility
methods. Due to negative performance impact did
call BU::getRecordWSOL() on every field, but
just pass the uid and pid.

However, for properly evaluating itemsProcFunc's, the
full record is usually required for context.

To provide the full record without the negative
performance impact are the `BU::getProcessedValue()`
and `BU:getProcessedValueExtra()` methods extended.
Calling code can now pass an already fetched full
row to the methods, which will then be forwarded
to the corresponding itemsProcFunc's.

All places in core are adjusted accordingly to
support itemsProcFunc resolving in as many
places as possible.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
  • Verified V +2 Done
    • Garvin Hicking +2
    • core-ci +1 CI

Issues 3

Files 10

Review log 57

  1. Garvin Hicking commented on patch set 1 09/20/24, 05:35

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/backend/Classes/Form/FieldWizard/DefaultLanguageDifferences.php * typo3/sysext/info/Classes/Controller/PageInformationController.php
  2. core-ci voted on patch set 1 V -1 09/20/24, 05:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66284

  3. Garvin Hicking uploaded patch set 2 V -1 09/20/24, 05:55

    Fix merge conflicts
  4. Garvin Hicking marked it ready for review 09/20/24, 05:55

  5. core-ci voted on patch set 2 V +1 09/20/24, 06:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66285

  6. Garvin Hicking voted on patch set 2 CR +2 V +2 09/20/24, 06:27

  7. Garvin Hicking merged patch set 3 09/20/24, 06:27