Review main Merged

86236[TASK] Streamline install tool module actions

Benjamin Kott CR +2 V +2 Normal +46 −25 updated 09/23/24, 07:40

Commit message

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Marvin Buchmann +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Marvin Buchmann +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 78

  1. Benjamin Kott uploaded patch set 1 09/20/24, 07:59

  2. core-ci voted on patch set 1 V +1 09/20/24, 08:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66295

  3. Marvin Buchmann voted on patch set 1 CR +1 V +1 09/23/24, 07:22

  4. Andreas Kienast voted on patch set 1 CR +1 V +1 09/23/24, 07:22

  5. Benjamin Franzke commented on patch set 1 CR -1 09/23/24, 07:23

    _install.scss:126

    Adds an undesired offset inside the modal-body. What should have been fixed by this margin? (I guess upgrade wizards, but the elements below already have margin top)
  6. Andreas Kienast voted on patch set 1 CR +2 V +2 09/23/24, 07:23

  7. Benjamin Franzke commented on patch set 1 CR 0 09/23/24, 07:28

    _install.scss:126 Reply

    nvm
  8. Andreas Kienast merged patch set 2 09/23/24, 07:40