86238[BUGFIX] Fix additional attribute handling in MediaViewHelper
Commit message
Review
-
Code review CR +2 Done
- Simon Praetorius +2
- Garvin Hicking +1
-
Verified V +2 Done
- Simon Praetorius +2
- Garvin Hicking +1
- core-ci +1 CI
Issues 1
Files 3
Review log 1417
-
Karsten Nowak uploaded patch set 1 09/20/24, 08:43
-
core-ci voted on patch set 1 V +1 09/20/24, 08:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66298
-
Simon Praetorius commented on patch set 1 09/20/24, 13:26
Can you add a test case that verifies the problem? -
Karsten Nowak commented on patch set 1 09/22/24, 18:55
Reply
Test case? What exactly do you have in mind? -
Simon Praetorius commented on patch set 1 09/22/24, 20:01
Reply
There are already some functional tests for the MediaViewHelper. Apparently they didn‘t cover the use case you describe. It would be great to cover the problem you discovered and fixed by that test to avoid potential regressions in the future. Here is the test file: https://github.com/TYPO3/typo3/blob/main/typo3/sysext/fluid/Tests/Functional/ViewHelpers/MediaViewHelperTest.php If you need any help, feel free to contact me via Slack! -
Karsten Nowak uploaded patch set 2
V +109/24/24, 15:58 -
core-ci voted on patch set 2 V +1 09/24/24, 16:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66510
-
Simon Praetorius voted on patch set 2 CR +1 V +1 09/24/24, 16:22
-
Simon Praetorius commented on patch set 2 09/24/24, 16:28
Reply
Done -
Garvin Hicking voted on patch set 2 CR +1 V +1 09/24/24, 16:33
-
Garvin Hicking commented on patch set 2 09/24/24, 16:35
Unsure about the commit message being written in first person, I just noticed...? -
Garvin Hicking voted on patch set 2 CR 0 09/24/24, 16:35
-
Simon Praetorius updated the commit message in patch set 3
CR +1V +109/24/24, 17:17 -
core-ci voted on patch set 3 V +1 09/24/24, 17:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66511
-
Garvin Hicking commented on patch set 3 CR +1 V +1 09/24/24, 19:27
Thanks!👌🏻 -
Simon Praetorius voted on patch set 3 CR +2 V +2 09/24/24, 19:52
-
Simon Praetorius merged patch set 4 09/24/24, 19:53