Review main Merged

86239[TASK] Add <f:debug> example to styleguide

Benjamin Franzke CR +2 V +2 Normal +243 −0 updated 09/23/24, 13:46

Commit message

Add a new component entry "Developer Tools" and a
console command `typo3 styleguide:example:var-dump`
to demonstrate the debug utility output.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Frank Nägler +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Frank Nägler +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 1219

  1. Benjamin Franzke uploaded patch set 1 09/20/24, 09:00

  2. core-ci voted on patch set 1 V -1 09/20/24, 09:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66301

  3. Benjamin Franzke uploaded patch set 2 V -1 09/20/24, 09:35

  4. core-ci voted on patch set 2 V -1 09/20/24, 09:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66302

  5. Benjamin Franzke uploaded patch set 3 V -1 09/20/24, 09:58

  6. core-ci voted on patch set 3 V -1 09/20/24, 10:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66307

  7. Benjamin Franzke uploaded patch set 4 V -1 09/20/24, 11:21

  8. core-ci voted on patch set 4 V -1 09/20/24, 11:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66320

  9. Benjamin Franzke uploaded patch set 5 V -1 09/20/24, 11:51

  10. core-ci voted on patch set 5 V +1 09/20/24, 12:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66321

  11. Andreas Kienast commented on patch set 5 09/23/24, 10:12

    VarDumpCommand.php:33

    nitpick: `Command::SUCCESS`
  12. Andreas Kienast uploaded patch set 6 V +1 09/23/24, 11:06

  13. Andreas Kienast commented on patch set 6 CR +1 V +1 09/23/24, 11:07

    VarDumpCommand.php:33 Reply

    Done
  14. core-ci voted on patch set 6 V +1 09/23/24, 11:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66432

  15. Frank Nägler uploaded patch set 7 CR +1 V +1 09/23/24, 13:25

  16. Frank Nägler voted on patch set 7 CR +1 V +1 09/23/24, 13:30

  17. core-ci voted on patch set 7 V +1 09/23/24, 13:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66442

  18. Andreas Kienast voted on patch set 7 CR +2 V +2 09/23/24, 13:46

  19. Andreas Kienast merged patch set 8 09/23/24, 13:46