Review main Merged

86240[TASK] Remove unused labels in live search

Peter Kraume CR +2 V +2 Easy +0 −15 updated 12/17/24, 21:53

Commit message

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1721

  1. Peter Kraume uploaded patch set 1 09/20/24, 10:07

  2. core-ci voted on patch set 1 V +1 09/20/24, 10:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66310

  3. Jasmina Ließmann commented on patch set 1 09/20/24, 10:44

    As a note: There is already a patch pending which cleans up this whole file (https://review.typo3.org/c/Packages/TYPO3.CMS/+/85826). My comment is not intended as a blocker.

    locallang_misc.xlf:423

    This label also appears to be unused.

    locallang_misc.xlf:426

    This label also appears to be unused.
  4. Peter Kraume uploaded patch set 2 V +1 09/20/24, 11:07

  5. core-ci voted on patch set 2 V +1 09/20/24, 11:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66315

  6. Jasmina Ließmann commented on patch set 2 09/20/24, 12:15

    locallang_misc.xlf:423 Reply

    Done

    locallang_misc.xlf:426 Reply

    Done
  7. Guido Schmechel voted on patch set 2 CR +1 V +1 10/03/24, 08:50

  8. Oliver Hader updated the commit message in patch set 3 CR +1 V +1 10/18/24, 14:01

  9. Simon Schaufelberger uploaded patch set 4 12/17/24, 18:59

  10. Simon Schaufelberger commented on patch set 4 CR +1 V +1 12/17/24, 18:59

    checked again if they are still not used.
  11. core-ci voted on patch set 4 V +1 12/17/24, 19:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71312

  12. Josef Glatz voted on patch set 4 CR +1 V +1 12/17/24, 19:08

  13. Oli Bartsch commented on patch set 4 V -1 12/17/24, 20:25

    I highly recommend to not remove labels from released LTS versions. While they are not directly defined as pubic API, they might be used anyways and removing them especially in priority bugfix versions IMO poses more risk of regressions than it brings any benefits.
  14. Simon Schaufelberger updated the commit message in patch set 5 CR +1 V +1 12/17/24, 20:32

  15. Simon Schaufelberger commented on patch set 5 12/17/24, 20:32

    Reply

    nothing easier than adjusting the release tags.
  16. Simon Schaufelberger voted on patch set 5 CR +1 V +1 12/17/24, 20:33

  17. Peter Kraume commented on patch set 5 12/17/24, 20:36

    Reply

    I think it is highly unlikely that anyone will use these labels in any other way. But I also have no problem if the change is limited to “main”.
  18. Simon Schaufelberger commented on patch set 5 12/17/24, 20:39

    Reply

    core team needs to decide. If people misuse these labels (which is very unlikely), then it's their fault.
  19. core-ci voted on patch set 5 V +1 12/17/24, 20:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71320

  20. Oli Bartsch commented on patch set 5 CR +2 V +2 12/17/24, 21:53

    Reply

    Done
  21. Oli Bartsch merged patch set 6 12/17/24, 21:53