86243[TASK] Make DebuggerUtility::var_dump output context aware
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Oli Bartsch +1
-
Verified V +2 Done
- Andreas Kienast +2
- Oli Bartsch +1
- core-ci +1 CI
Issues 1
Files 4
Review log 2232
Show 47 earlier messages
-
Benjamin Franzke uploaded patch set 1 09/20/24, 12:59
-
core-ci voted on patch set 1 V +1 09/20/24, 13:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66334
-
Benjamin Franzke uploaded patch set 2
V +109/23/24, 10:08 -
core-ci voted on patch set 2 V +1 09/23/24, 10:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66431
-
Benjamin Franzke uploaded patch set 3
V +109/24/24, 07:24 -
core-ci voted on patch set 3 V +1 09/24/24, 07:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66480
-
Andreas Kienast commented on patch set 3 09/24/24, 07:45
IMO the contrast of the lines is in dark mode too high.
-
Benjamin Franzke uploaded patch set 4
V +109/27/24, 12:58 -
Benjamin Franzke commented on patch set 4 09/27/24, 12:58
Reply
ack, done. -
Benjamin Franzke uploaded patch set 5 09/27/24, 12:59
-
core-ci voted on patch set 4 V -1 09/27/24, 13:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66750
-
core-ci voted on patch set 5 V -1 09/27/24, 13:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66751
-
Benjamin Franzke uploaded patch set 6
V -109/27/24, 13:06 -
core-ci voted on patch set 6 V +1 09/27/24, 13:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66752
-
Andreas Kienast commented on patch set 6 09/27/24, 13:14
_debugger-utility.scss:4I'd go with 3% here. OTOH, we may remove the "striping" completely? -
Simon Praetorius commented on patch set 6 09/27/24, 17:01
DebuggerUtility.php:653Maybe I don't get the implementation details, but this looks over-engineered and hard to grasp to me. No -1, just wanted to leave this thought here. -
Benjamin Franzke uploaded patch set 7
V +109/30/24, 06:54 -
Benjamin Franzke commented on patch set 7 09/30/24, 06:54
_debugger-utility.scss:4Reply3% is fine by me.DebuggerUtility.php:653ReplyI can't really understand why this looks over-engineered (it's rather under-engineered, as it's a plain simple array-to-string conversion implemented in a very blunt way – that basically the opposite of over-engineered). Anyway, I moved this code into a separate function with the hope to be easier to understand. -
core-ci voted on patch set 7 V -1 09/30/24, 07:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66831
-
Benjamin Franzke uploaded patch set 8
V -109/30/24, 07:08 -
Benjamin Franzke uploaded patch set 9 09/30/24, 07:10
-
core-ci voted on patch set 8 V -1 09/30/24, 07:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66832
-
core-ci voted on patch set 9 V -1 09/30/24, 07:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66833
-
Benjamin Franzke uploaded patch set 10
V -109/30/24, 07:19 -
core-ci voted on patch set 10 V +1 09/30/24, 07:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66834
-
Oli Bartsch commented on patch set 10 09/30/24, 19:35
DebuggerUtility.php:807Could we get a quick unit test for this utility method? -
Benjamin Franzke commented on patch set 10 10/01/24, 06:20
DebuggerUtility.php:807Replyno, I only added it for readability, because of https://review.typo3.org/c/Packages/TYPO3.CMS/+/86243/10#message-608529ed29f3161482242f031b6cae7b719d406b This is really not meant to be tested, sorry. -
Andreas Kienast voted on patch set 10 CR +1 V +1 10/01/24, 06:30
-
Andreas Kienast commented on patch set 10 10/01/24, 06:32
DebuggerUtility.php:807ReplyIf this would break, I think existing tests that check the generated markup would also fail. Fine for me. -
Oli Bartsch commented on patch set 10 CR +1 V +1 10/01/24, 14:43
DebuggerUtility.php:807ReplyACK -
Andreas Kienast voted on patch set 10 CR +2 V +2 10/01/24, 15:16
-
Andreas Kienast merged patch set 11 10/01/24, 15:16