Review main Merged

86244[TASK] Make ClassLoadingInformationGenerator stateless

Christian Kuhn CR +2 V +2 Hard +123 −194 updated 09/20/24, 14:25

Commit message

* Modernize (internal) ClassLoadingInformationGenerator with
  native type hints.
* Remove __construct() and hand over state to methods as
  needed. Note property $classLoader was unused.
* Instantiate class using new() in the static methods
  of ClassLoadingInformation since this early bootstrap
  low level class can not be tampered with by extensions.
* Declare ClassLoadingInformationGenerator readonly.
* Cosmetics like having public methods on top of class.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 4

Review log 57

  1. Christian Kuhn uploaded patch set 1 09/20/24, 13:18

  2. core-ci voted on patch set 1 V -1 09/20/24, 13:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66336

  3. Christian Kuhn uploaded patch set 2 V -1 09/20/24, 13:32

  4. core-ci voted on patch set 2 V +1 09/20/24, 13:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66338

  5. Stefan Bürk voted on patch set 2 CR +1 V +1 09/20/24, 14:05

  6. Anja Leichsenring voted on patch set 2 CR +2 V +2 09/20/24, 14:25

  7. Anja Leichsenring merged patch set 3 09/20/24, 14:25