Review main Merged

86245[TASK] Use RecordPropertyClosure for more field transformations

Oli Bartsch CR +2 V +2 Easy +18 −9 updated 09/23/24, 07:57

Commit message

RecordPropertyClosure has been introduced to
allow resolving record relations once they are
accessed (lazy loading). However not only resolving
relations might be a costly task, also processing
flexform structures or converting huge JSON strings.

Therefore, to further reduce the performance impact
of record field transformation, RecordPropertyClosure is
now also used for additional field types: Flex, Json
and Link.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 68

  1. Oli Bartsch uploaded patch set 1 09/20/24, 13:25

  2. core-ci voted on patch set 1 V +1 09/20/24, 13:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66337

  3. Nikita Hovratov voted on patch set 1 CR +1 09/20/24, 13:45

  4. Benjamin Franzke uploaded patch set 2 CR +1 V +1 09/21/24, 16:24

  5. Benjamin Franzke commented on patch set 2 09/21/24, 16:24

    This is not a full fix for the performance problem described in #105054 (it's still slow, if flexforms are accessed and needs another fix: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86197 ), but as discussed on friday, sth we definetly want. I therefore created a new ticket for this one.
  6. core-ci voted on patch set 2 V +1 09/21/24, 16:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66369

  7. Andreas Kienast commented on patch set 2 CR +2 V +2 09/23/24, 07:57

    <3
  8. Andreas Kienast merged patch set 3 09/23/24, 07:57