Review main Merged

86246[TASK] Improve input[type=range] with context-aware styling

Benjamin Kott CR +2 V +2 Hard +140 −247 updated 09/23/24, 08:17

Commit message

Replaced the internal `.slider` classes with `.form-range` for
input[type=range] elements. Simplified the styling and made
it context-aware to enhance maintainability and adaptability.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Marvin Buchmann +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Marvin Buchmann +1
    • core-ci +1 CI

Issues 1

Files 9

Review log 1016

  1. Benjamin Kott uploaded patch set 1 09/20/24, 13:46

  2. core-ci voted on patch set 1 V -1 09/20/24, 13:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66339

  3. Benjamin Kott uploaded patch set 2 V -1 09/23/24, 06:57

  4. core-ci voted on patch set 2 V +1 09/23/24, 07:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66411

  5. Andreas Kienast commented on patch set 2 CR -1 09/23/24, 07:08

    _form-range.scss:13

    This property duplicates line 8.
  6. Benjamin Kott uploaded patch set 3 CR -1 V +1 09/23/24, 07:14

  7. Benjamin Kott uploaded patch set 4 09/23/24, 07:18

  8. Andreas Kienast commented on patch set 4 CR +1 V +1 09/23/24, 07:19

    _form-range.scss:13 Reply

    Done
  9. core-ci voted on patch set 3 V -1 09/23/24, 07:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66413

  10. core-ci voted on patch set 4 V -1 09/23/24, 07:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66414

  11. core-ci voted on patch set 4 V +1 09/23/24, 07:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66414

  12. Benjamin Kott uploaded patch set 5 CR +1 V +1 09/23/24, 07:53

  13. Marvin Buchmann voted on patch set 5 CR +1 V +1 09/23/24, 07:53

  14. core-ci voted on patch set 5 V +1 09/23/24, 08:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66418

  15. Andreas Kienast voted on patch set 5 CR +2 V +2 09/23/24, 08:17

  16. Andreas Kienast merged patch set 6 09/23/24, 08:17