Review main Merged

86249[BUGFIX] Remove unwanted spacing of table in "Detailed statistics"

Sébastien Delcroix CR +2 V +2 Easy +6 −6 updated 10/03/24, 09:28

Commit message

The bottom margin of a table is set to 0 if it's a direct child of
.table-fit.
In the "Detailed statistics" view of Indexing module, due to the
"typo3-indexed-search-statistics" custom element wrapping the table,
this one is not a direct child anymore.

This patch moves the custom element one level upper and adapts the
Javascript accordingly so the "Words found on this page" table can
stay sortable.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Jasmina Ließmann +1
    • Guido Schmechel +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Jasmina Ließmann +1
    • Guido Schmechel +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 68

  1. Sébastien Delcroix uploaded patch set 1 09/20/24, 16:24

  2. core-ci voted on patch set 1 V +1 09/20/24, 16:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66344

  3. Sébastien Delcroix updated the commit message in patch set 2 V +1 09/20/24, 16:56

  4. core-ci voted on patch set 2 V +1 09/20/24, 17:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66345

  5. Jasmina Ließmann voted on patch set 2 CR +1 V +1 09/23/24, 19:22

  6. Guido Schmechel voted on patch set 2 CR +1 V +1 10/03/24, 08:34

  7. Garvin Hicking voted on patch set 2 CR +2 V +2 10/03/24, 09:27

  8. Garvin Hicking merged patch set 3 10/03/24, 09:28