Review 12.4 Merged

86251[TASK] Raise "phpstan/phpstan":"^1.12.4"

Anja Leichsenring CR +2 V +2 Easy +7 −27 updated 09/21/24, 07:51

Commit message

PHPStan released a new version that allows
to remove three entries from the baseline file,
because the former code smells are not detected
as such anymore. The version raised and the entries
removed allow the pipeline to run green again.

Used command(s):

> Build/Scripts/runTests.sh -s composer -- \
  require --dev "phpstan/phpstan":"^1.12.4"

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 34

  1. Anja Leichsenring uploaded patch set 1 09/21/24, 06:26

  2. core-ci voted on patch set 1 V +1 09/21/24, 06:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66359

  3. Stefan Bürk voted on patch set 1 CR +2 V +2 09/21/24, 07:51

  4. Stefan Bürk merged patch set 2 09/21/24, 07:51