Review main Merged

86256[TASK] Migrate PageCreationWithDragAndDropCest.php to Playwright

Jochen Roth CR +2 V +2 Hard +210 −324 updated 12/17/24, 15:04

Commit message

The codeception acceptance test PageCreationWithDragAndDropCest.php
had to be skipped since the page tree was migrated to use native
browser drag-drop functionality in #102125, because codeception/webdriver
can not emulate native drag-drop events.

The test is now migrated to an end-to-end test based on Playwright.
Playwright is already used for accessibility tests and can now act as a
modern replacement for codeception, as it allows to send real mouse and
keyboard instructions instead of faking DOM events.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Benjamin Kott +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Benjamin Kott +1
    • core-ci +1 CI

Issues 1

Files 10

Review log 2130

Show 45 earlier messages
  1. Jochen Roth uploaded patch set 1 09/22/24, 12:21

  2. Jochen Roth updated the commit message in patch set 2 09/22/24, 12:22

  3. Jochen Roth uploaded patch set 3 09/22/24, 12:27

  4. core-ci voted on patch set 3 V +1 09/22/24, 12:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66394

  5. Jochen Roth commented on patch set 3 09/22/24, 12:44

    Please have a look :-)
  1. Benjamin Franzke commented on patch set 3 CR -1 09/23/24, 11:55

    Reply

    Very cool Jochen. Thanks a bunch, I'll have a look! (-1 as I will try to tacke some details)

    runTests.sh:178

    Good to have this centralized. Now that we want to run e2e – and not just accessibility – we probably need to look into supporting all db engines for playwright, not just mariadb. And of course classic mode… That's not a blocker though (IMO), as this already improves testing coverage. But we'll at least will need a comment/todo here.

    backend.spec.ts:4

    We should not hardcode a prefix "/" but make the entry point configurable (as in accessibility tests)
  2. Jochen Roth uploaded patch set 4 CR -1 V +1 09/23/24, 19:14

  3. Jochen Roth commented on patch set 4 09/23/24, 19:17

    runTests.sh:178 Reply

    Done

    backend.spec.ts:4 Reply

    Removed this test. It does not belong in here. But removed the hardcoded "/typo3" in page-creation-with-drag-and-drop.spec.ts
  4. core-ci voted on patch set 4 V +1 09/23/24, 19:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66455

  5. Jochen Roth updated the commit message in patch set 5 V +1 09/23/24, 19:23

  6. core-ci voted on patch set 5 V +1 09/23/24, 19:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66456

  7. Benjamin Franzke uploaded patch set 6 V +1 12/17/24, 08:10

  8. core-ci voted on patch set 6 V +1 12/17/24, 08:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71243

  9. Benjamin Franzke uploaded patch set 7 V +1 12/17/24, 08:21

  10. core-ci voted on patch set 7 V +1 12/17/24, 08:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71246

  11. Benjamin Franzke uploaded patch set 8 V +1 12/17/24, 11:03

  12. core-ci voted on patch set 8 V +1 12/17/24, 11:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71259

  13. Benjamin Franzke uploaded patch set 9 CR +1 V +1 12/17/24, 11:19

  14. core-ci voted on patch set 9 V +1 12/17/24, 11:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71261

  15. Benjamin Kott commented on patch set 9 CR -1 12/17/24, 12:12

    page-creation-with-drag-and-drop.spec.ts:61

    why do we insert the title here first and then unset it again?
  16. Benjamin Franzke uploaded patch set 10 CR +1 V +1 12/17/24, 13:17

  17. Benjamin Franzke commented on patch set 10 12/17/24, 13:17

    page-creation-with-drag-and-drop.spec.ts:61 Reply

    no, removed.
  18. core-ci voted on patch set 10 V +1 12/17/24, 13:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71271

  19. Christian Kuhn commented on patch set 10 12/17/24, 13:38

    e2e.yml:14

    i'd prefer to run the nightly suite with the 'upper flank' of php - currently 8.4

    e2e.yml:15

    i'd prefer to run pre-merge with the 'lower flank' of php - currently 8.2 in main & v13.
  20. Benjamin Franzke uploaded patch set 11 CR +1 V +1 12/17/24, 14:52

  21. Benjamin Franzke commented on patch set 11 12/17/24, 14:52

    e2e.yml:14 Reply

    Done

    e2e.yml:15 Reply

    Done
  22. Benjamin Kott voted on patch set 11 CR +1 V +1 12/17/24, 14:53

  23. Benjamin Franzke voted on patch set 11 CR +2 V +2 12/17/24, 14:54

  24. core-ci voted on patch set 11 V +1 12/17/24, 15:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71282

  25. Benjamin Franzke merged patch set 12 12/17/24, 15:04