86256[TASK] Migrate PageCreationWithDragAndDropCest.php to Playwright
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Benjamin Kott +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Benjamin Kott +1
- core-ci +1 CI
Issues 1
Files 10
- Build/gitlab-ci/nightly/e2e.yml2new+14 −0
- Build/gitlab-ci/pre-merge/e2e.yml2new+15 −0
- Build/Scripts/runTests.sh2+88 −59
- Build/tests/playwright/e2e/page-creation-with-drag-and-drop.spec.ts2new+81 −0
- Build/tests/playwright/config.ts+1 −1
- Build/gitlab-ci.yml+2 −0
- Build/playwright.config.ts+8 −0
- typo3/sysext/core/Tests/Acceptance/Application/PageTree/PageCreationWithDragAndDropCest.phpdeleted+0 −101
- typo3/sysext/core/Tests/Acceptance/Support/Helper/Mouse.phpdeleted+0 −131
- typo3/sysext/core/Tests/Acceptance/Support/Helper/PageTree.php+1 −32
Review log 2130
Show 45 earlier messages
-
Jochen Roth uploaded patch set 1 09/22/24, 12:21
-
Jochen Roth updated the commit message in patch set 2 09/22/24, 12:22
-
Jochen Roth uploaded patch set 3 09/22/24, 12:27
-
core-ci voted on patch set 3 V +1 09/22/24, 12:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66394
-
Jochen Roth commented on patch set 3 09/22/24, 12:44
Please have a look :-)
-
Benjamin Franzke commented on patch set 3 CR -1 09/23/24, 11:55
Reply
Very cool Jochen. Thanks a bunch, I'll have a look! (-1 as I will try to tacke some details)runTests.sh:178Good to have this centralized. Now that we want to run e2e – and not just accessibility – we probably need to look into supporting all db engines for playwright, not just mariadb. And of course classic mode… That's not a blocker though (IMO), as this already improves testing coverage. But we'll at least will need a comment/todo here.backend.spec.ts:4We should not hardcode a prefix "/" but make the entry point configurable (as in accessibility tests) -
Jochen Roth uploaded patch set 4
CR -1V +109/23/24, 19:14 -
Jochen Roth commented on patch set 4 09/23/24, 19:17
runTests.sh:178ReplyDonebackend.spec.ts:4ReplyRemoved this test. It does not belong in here. But removed the hardcoded "/typo3" in page-creation-with-drag-and-drop.spec.ts -
core-ci voted on patch set 4 V +1 09/23/24, 19:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66455
-
Jochen Roth updated the commit message in patch set 5
V +109/23/24, 19:23 -
core-ci voted on patch set 5 V +1 09/23/24, 19:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66456
-
Benjamin Franzke uploaded patch set 6
V +112/17/24, 08:10 -
core-ci voted on patch set 6 V +1 12/17/24, 08:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71243
-
Benjamin Franzke uploaded patch set 7
V +112/17/24, 08:21 -
core-ci voted on patch set 7 V +1 12/17/24, 08:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71246
-
Benjamin Franzke uploaded patch set 8
V +112/17/24, 11:03 -
core-ci voted on patch set 8 V +1 12/17/24, 11:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71259
-
Benjamin Franzke uploaded patch set 9
CR +1V +112/17/24, 11:19 -
core-ci voted on patch set 9 V +1 12/17/24, 11:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71261
-
Benjamin Kott commented on patch set 9 CR -1 12/17/24, 12:12
page-creation-with-drag-and-drop.spec.ts:61why do we insert the title here first and then unset it again? -
Benjamin Franzke uploaded patch set 10
CR +1V +112/17/24, 13:17 -
Benjamin Franzke commented on patch set 10 12/17/24, 13:17
page-creation-with-drag-and-drop.spec.ts:61Replyno, removed. -
core-ci voted on patch set 10 V +1 12/17/24, 13:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71271
-
Christian Kuhn commented on patch set 10 12/17/24, 13:38
e2e.yml:14i'd prefer to run the nightly suite with the 'upper flank' of php - currently 8.4e2e.yml:15i'd prefer to run pre-merge with the 'lower flank' of php - currently 8.2 in main & v13. -
Benjamin Franzke uploaded patch set 11
CR +1V +112/17/24, 14:52 -
Benjamin Franzke commented on patch set 11 12/17/24, 14:52
e2e.yml:14ReplyDonee2e.yml:15ReplyDone -
Benjamin Kott voted on patch set 11 CR +1 V +1 12/17/24, 14:53
-
Benjamin Franzke voted on patch set 11 CR +2 V +2 12/17/24, 14:54
-
core-ci voted on patch set 11 V +1 12/17/24, 15:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71282
-
Benjamin Franzke merged patch set 12 12/17/24, 15:04