Review main Merged

86257[BUGFIX] ADMCMD_* params missing for split preview URLs

Philipp Kitzberger CR +2 V +2 Easy +43 −6 updated 03/28/25, 07:35

Commit message

This makes sure the two iframe URLs of the workspace split preview
contain the necessary GET parameters:

* ADMCMD_simUser
* ADMCMD_simTime

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Markus Klein +1
    • Johannes Kasberger +1
  • Verified V +2 Done
    • Benni Mack +2
    • Markus Klein +1
    • Johannes Kasberger +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 1928

Show 23 earlier messages
  1. Philipp Kitzberger uploaded patch set 1 09/22/24, 14:08

  2. core-ci voted on patch set 1 V +1 09/22/24, 14:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66395

  3. Philipp Kitzberger uploaded patch set 2 V +1 10/10/24, 13:02

  1. core-ci voted on patch set 2 V -1 10/10/24, 13:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67510

  2. Philipp Kitzberger rebased onto patch set 3 V -1 10/22/24, 16:31

  3. core-ci voted on patch set 3 V +1 10/22/24, 16:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68389

  4. Benni Mack updated the commit message in patch set 4 V +1 03/27/25, 17:15

  5. Benni Mack commented on patch set 5 03/27/25, 17:15

    Published edit on patch set 4.
  6. Benni Mack commented on patch set 6 03/27/25, 17:17

    Published edit on patch set 5.
  7. Benni Mack commented on patch set 6 CR +1 03/27/25, 17:17

    I personally don't like the mixture of static and non-static code now, but I think it's OK for now...
  8. Simon Schaufelberger updated the commit message in patch set 7 CR +1 03/27/25, 17:22

  9. core-ci voted on patch set 4 V -1 03/27/25, 17:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76488

  10. core-ci voted on patch set 5 V -1 03/27/25, 17:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76489

  11. Simon Schaufelberger commented on patch set 7 03/27/25, 17:23

    #96658 also states that the bug exists in TYPO3 11. Should we also backport to v12?
  12. core-ci voted on patch set 6 V -1 03/27/25, 17:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76490

  13. core-ci voted on patch set 7 V -1 03/27/25, 17:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76491

  14. Benni Mack commented on patch set 7 03/27/25, 19:48

    Reply

    looks like the backport won't be trivial. that's a tricky thing to do and might take a few hours... let's try to make the patch green first. OK? Are you up for it?
  15. Markus Klein commented on patch set 7 03/27/25, 20:04

    Reply

    We just ran into this issue today with v12
  16. Simon Schaufelberger rebased onto patch set 8 V -1 03/27/25, 20:28

  17. core-ci voted on patch set 8 V +1 03/27/25, 20:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76505

  18. Benni Mack voted on patch set 8 CR +1 V +1 03/27/25, 20:39

  19. Benni Mack updated the commit message in patch set 9 CR +1 V +1 03/27/25, 20:41

  20. Benni Mack voted on patch set 9 CR +1 V +1 03/27/25, 20:41

  21. core-ci voted on patch set 9 V +1 03/27/25, 20:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76507

  22. Markus Klein voted on patch set 9 CR +1 V +1 03/28/25, 07:29

  23. Johannes Kasberger voted on patch set 9 CR +1 V +1 03/28/25, 07:32

  24. Benni Mack voted on patch set 9 CR +2 V +2 03/28/25, 07:35

  25. Benni Mack merged patch set 10 03/28/25, 07:35