86258[BUGFIX] Use correct default value for extTarget in tsref.xml
Commit message
Review
-
Code review CR +2 Done
- Garvin Hicking +2
- Benjamin Franzke +1
- Benni Mack +1
-
Verified V +2 Done
- Garvin Hicking +2
- Benjamin Franzke +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1722
-
Chris Müller uploaded patch set 1 09/22/24, 15:34
-
core-ci voted on patch set 1 V +1 09/22/24, 15:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66397
-
Benjamin Franzke commented on patch set 1 09/23/24, 06:00
Hm, there is no real default value AFAICS since > 37897: [TASK] Don't define extTarget = _top as default | https://review.typo3.org/c/Packages/TYPO3.CMS/+/37897 extTarget was defined to be _top back then, and since the mentioned change it was up to css_styled_content, and now fluid_styled_content to provide a default value, but that's no general default value. so there is no default now, it should probably be `''`: https://github.com/TYPO3/typo3/blob/main/typo3/sysext/frontend/Classes/Typolink/AbstractTypolinkBuilder.php#L181-L183 -
Benni Mack updated the commit message in patch set 2
V +110/18/24, 13:54 -
Benni Mack rebased onto patch set 3 11/18/24, 08:43
-
core-ci voted on patch set 3 V +1 11/18/24, 08:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69569
-
Benni Mack voted on patch set 3 CR +1 V +1 11/18/24, 08:50
-
Benni Mack commented on patch set 4
CR +1V +111/18/24, 09:03Published edit on patch set 3. -
core-ci voted on patch set 4 V +1 11/18/24, 09:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69571
-
Benni Mack voted on patch set 4 CR +1 V +1 11/18/24, 10:23
-
Benni Mack commented on patch set 4 V 0 11/18/24, 10:24
gotta test first. -
Benjamin Franzke commented on patch set 4 CR -1 11/18/24, 10:33
tsref.xml:354ns -
Chris Müller commented on patch set 5
CR +1V +111/18/24, 13:48Published edit on patch set 4. -
core-ci voted on patch set 5 V +1 11/18/24, 13:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69597
-
Chris Müller commented on patch set 5 11/18/24, 17:06
tsref.xml:354ReplyDone -
Garvin Hicking commented on patch set 5 11/18/24, 23:33
tsref.xml:354"blank installation" means "without FSC"? I think this sounds a bit misleading due to the "_blank" value before. (Question: Should this be labelled task/docs rather than a bugfix? This is display only, not functional, right?) -
Benjamin Franzke commented on patch set 6
V +112/11/24, 09:02Published edit on patch set 5. -
Benjamin Franzke commented on patch set 6 CR +1 V +1 12/11/24, 09:03
tsref.xml:354ReplyBUGFIX is fine as the autocompletion is wrong. Changed the wording to avoid the term "blank", hope that's fine now. -
core-ci voted on patch set 6 V +1 12/11/24, 09:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70901
-
Benni Mack voted on patch set 6 CR +1 V +1 12/11/24, 09:15
-
Garvin Hicking voted on patch set 6 CR +2 V +2 12/11/24, 09:19
-
Garvin Hicking merged patch set 7 12/11/24, 10:13