Review main Merged

86263[TASK] Use return code constants in `GeneratorCommand`

Andreas Kienast CR +2 V +2 Easy +6 −15 updated 09/23/24, 11:25

Commit message

Symfony's `Command` class provides constants for common return codes.
Those codes are now used in styleguide's `GeneratorCommand`.
In the same run, unused return type declarations of internal methods
have been replaced with `void`.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 56

  1. Andreas Kienast uploaded patch set 1 09/23/24, 11:16

  2. Stefan Bürk voted on patch set 1 CR +1 09/23/24, 11:19

  3. core-ci voted on patch set 1 V +1 09/23/24, 11:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66433

  4. Stefan Bürk voted on patch set 1 V +1 09/23/24, 11:21

  5. Benjamin Franzke voted on patch set 1 CR +2 V +2 09/23/24, 11:25

  6. Benjamin Franzke merged patch set 2 09/23/24, 11:25