Review main Merged

86270[BUGFIX] Save collapse-state of scheduler tasks groups

Sébastien Delcroix CR +2 V +2 Easy +1 −1 updated 10/03/24, 09:30

Commit message

In scheduler module, tasks can be gathered in groups. Each group,
including the one for unassigned tasks, displays them in a table that
can be collapsed.
Groups can also be reordered.

Groups collapsed states and order are saved in UC.

Prior to this patch, collapsed states were wrongly saved because the
saved key for each table was based on the index of the group, which can
change depending on the groups order.
Now the saved key is using the group id which stays unique, except for
the unassigned tasks group which is always the first one (equivalent to
group id "0").

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Thomas Hohn +1
    • Oli Bartsch +1
    • Guido Schmechel +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Oli Bartsch +1
    • Guido Schmechel +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 67

  1. Sébastien Delcroix uploaded patch set 1 09/23/24, 21:21

  2. core-ci voted on patch set 1 V +1 09/23/24, 21:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66459

  3. Thomas Hohn voted on patch set 1 CR +1 09/24/24, 06:20

  4. Oli Bartsch voted on patch set 1 CR +1 V +1 09/24/24, 07:18

  5. Guido Schmechel voted on patch set 1 CR +1 V +1 10/03/24, 08:54

  6. Garvin Hicking voted on patch set 1 CR +2 V +2 10/03/24, 09:20

  7. Garvin Hicking merged patch set 2 10/03/24, 09:30