Review main Merged

86271[BUGFIX] Properly align form labels in installation wizard

Jasmina Ließmann CR +2 V +2 Expert +555 −616 updated 09/27/24, 08:56

Commit message

With the gradual removal of Bootstrap, form styling was only partially
adopted. As a result, "floating labels" were no longer correctly
displayed within the corresponding field, but incorrectly displayed
below it.

This patch fixes the incorrect display in the installation wizard.
Since these were the only occurrences of these "floating labels",
the corresponding styling was removed.

In the course of the work, some fields and paragraphs were rearranged
and wording was updated.

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benjamin Kott +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 9

Review log 1118

  1. Jasmina Ließmann uploaded patch set 1 09/23/24, 21:48

  2. core-ci voted on patch set 1 V +1 09/23/24, 21:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66460

  3. Jasmina Ließmann uploaded patch set 2 V +1 09/23/24, 22:09

  4. core-ci voted on patch set 2 V +1 09/23/24, 22:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66462

  5. Jasmina Ließmann uploaded patch set 3 V +1 09/25/24, 16:08

  6. Jasmina Ließmann uploaded patch set 4 09/25/24, 16:13

  7. core-ci voted on patch set 3 V -1 09/25/24, 16:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66612

  8. Jasmina Ließmann uploaded patch set 5 09/25/24, 16:17

  9. core-ci voted on patch set 4 V -1 09/25/24, 16:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66613

  10. core-ci voted on patch set 5 V -1 09/25/24, 16:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66614

  11. Jasmina Ließmann uploaded patch set 6 V -1 09/25/24, 16:26

  12. core-ci voted on patch set 6 V +1 09/25/24, 16:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66615

  13. Jasmina Ließmann uploaded patch set 7 V +1 09/25/24, 17:16

  14. core-ci voted on patch set 7 V +1 09/25/24, 17:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66616

  15. Stefan Bürk commented on patch set 7 CR +1 V +1 09/26/24, 07:43

    For me it works and looks good. However, I guess that either @akienast@scripting-base.de or @benjamin.kott@outlook.com may have a look if the css changes influences other parts - clicked around but could not see anything obvious broken now in the rest of the backend. Thanks Jasmina for taking care of the installer.
  16. Benjamin Kott commented on patch set 7 CR -1 09/27/24, 08:39

    on it, will add a prepatch
  17. Benjamin Kott voted on patch set 7 CR +2 V +2 09/27/24, 08:56

  18. Benjamin Kott merged patch set 8 09/27/24, 08:56