86271[BUGFIX] Properly align form labels in installation wizard
Commit message
Review
-
Code review CR +2 Done
- Benjamin Kott +2
- Stefan Bürk +1
-
Verified V +2 Done
- Benjamin Kott +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 9
- Build/Sources/Sass/component/forms/_input-group.scss+6 −20
- typo3/sysext/backend/Resources/Public/Css/backend.css+4 −5
- typo3/sysext/core/Tests/Acceptance/Install/Mysql/BlankPageCest.php+3 −3
- typo3/sysext/core/Tests/Acceptance/Install/Postgresql/BlankPageCest.php+3 −3
- typo3/sysext/core/Tests/Acceptance/Install/Sqlite/BlankPageCest.php+3 −3
- typo3/sysext/install/Resources/Private/Templates/Installer/ShowDatabaseConnect.html+367 −423
- typo3/sysext/install/Resources/Private/Templates/Installer/ShowDatabaseData.html+71 −74
- typo3/sysext/install/Resources/Private/Templates/Installer/ShowDatabaseSelect.html+74 −65
- typo3/sysext/install/Resources/Private/Templates/Installer/ShowDefaultConfiguration.html+24 −20
Review log 1118
-
Jasmina Ließmann uploaded patch set 1 09/23/24, 21:48
-
core-ci voted on patch set 1 V +1 09/23/24, 21:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66460
-
Jasmina Ließmann uploaded patch set 2
V +109/23/24, 22:09 -
core-ci voted on patch set 2 V +1 09/23/24, 22:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66462
-
Jasmina Ließmann uploaded patch set 3
V +109/25/24, 16:08 -
Jasmina Ließmann uploaded patch set 4 09/25/24, 16:13
-
core-ci voted on patch set 3 V -1 09/25/24, 16:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66612
-
Jasmina Ließmann uploaded patch set 5 09/25/24, 16:17
-
core-ci voted on patch set 4 V -1 09/25/24, 16:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66613
-
core-ci voted on patch set 5 V -1 09/25/24, 16:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66614
-
Jasmina Ließmann uploaded patch set 6
V -109/25/24, 16:26 -
core-ci voted on patch set 6 V +1 09/25/24, 16:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66615
-
Jasmina Ließmann uploaded patch set 7
V +109/25/24, 17:16 -
core-ci voted on patch set 7 V +1 09/25/24, 17:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66616
-
Stefan Bürk commented on patch set 7 CR +1 V +1 09/26/24, 07:43
For me it works and looks good. However, I guess that either @akienast@scripting-base.de or @benjamin.kott@outlook.com may have a look if the css changes influences other parts - clicked around but could not see anything obvious broken now in the rest of the backend. Thanks Jasmina for taking care of the installer. -
Benjamin Kott commented on patch set 7 CR -1 09/27/24, 08:39
on it, will add a prepatch -
Benjamin Kott voted on patch set 7 CR +2 V +2 09/27/24, 08:56
-
Benjamin Kott merged patch set 8 09/27/24, 08:56