Review main Merged

86293[TASK] Remove obsolete `InvocationMocker` from `DebuggerUtility` denylist

Andreas Kienast CR +2 V +2 Easy +0 −1 updated 09/24/24, 07:13

Commit message

The `DebuggerUtility` class contains a denylist to ignore certain
classes in the rendering, mostly to avoid memory leaks. One entry is
related to PHPUnit: `PHPUnit_Framework_MockObject_InvocationMocker`.

This entry has been there since the initial backport of
`DebuggerUtility` from FLOW3.

`InvocationMocker` has been namespaced for quite some time, therefore
we're dealing with a dead entry. Also, `DebuggerUtility` is rather a bad
choice when debugging tests, there are more sophisticated tools for this
(e.g. xdebug).

For said reasons, the entry is now removed without substitution.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Garvin Hicking +1
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Garvin Hicking +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 56

  1. Andreas Kienast uploaded patch set 1 09/24/24, 06:52

  2. Garvin Hicking voted on patch set 1 CR +1 V +1 09/24/24, 06:55

  3. core-ci voted on patch set 1 V +1 09/24/24, 07:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66477

  4. Benni Mack voted on patch set 1 CR +1 V +1 09/24/24, 07:06

  5. Andreas Kienast voted on patch set 1 CR +2 V +2 09/24/24, 07:13

  6. Andreas Kienast merged patch set 2 09/24/24, 07:13