86294[TASK] Use progress bar component in file upload
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Benni Mack +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 6
- Build/Sources/Sass/component/_table.scss+5 −0
- Build/Sources/Sass/component/_upload-queue.scss+0 −67
- Build/Sources/TypeScript/backend/drag-uploader.ts7+24 −41
- typo3/sysext/backend/Resources/Public/Css/backend.css+1 −5
- typo3/sysext/backend/Resources/Public/JavaScript/drag-uploader.js+1 −1
- typo3/sysext/core/Resources/Private/Language/locallang_core.xlf2+3 −0
Review log 1620
-
Andreas Kienast uploaded patch set 1 09/24/24, 08:39
-
core-ci voted on patch set 1 V +1 09/24/24, 08:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66481
-
Benjamin Franzke uploaded patch set 2
V +109/24/24, 09:50 -
Benjamin Franzke commented on patch set 2 09/24/24, 09:50
drag-uploader.ts:764This should probably some label like: `Uploading… 56%`drag-uploader.ts:778label: `Upload complete.`? -
Benjamin Franzke uploaded patch set 3
CR +1V +109/24/24, 09:51 -
core-ci voted on patch set 3 V +1 09/24/24, 09:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66485
-
Andreas Kienast commented on patch set 3 09/24/24, 10:13
drag-uploader.ts:775The label says "Upload complete! Filelist reloading..." but the file list does not reload automatically. -
Benjamin Franzke commented on patch set 3 CR 0 V 0 09/24/24, 10:24
drag-uploader.ts:775Replyack, I was fine with it, because it had some delay until it showed the metadata. But a new label would be even better 👍 -
Andreas Kienast uploaded patch set 4
V +109/24/24, 11:38 -
core-ci voted on patch set 4 V +1 09/24/24, 11:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66490
-
Andreas Kienast commented on patch set 4 09/24/24, 11:44
drag-uploader.ts:775ReplyI hope the approach I just pushed is better. -
Benjamin Franzke commented on patch set 4 09/25/24, 06:31
locallang_core.xlf:691resname is outdated -
Andreas Kienast commented on patch set 4 CR -1 09/25/24, 06:48
locallang_core.xlf:691ReplyAcknowledged -
Andreas Kienast uploaded patch set 5
CR -1V +109/25/24, 06:49 -
core-ci voted on patch set 5 V +1 09/25/24, 06:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66541
-
Andreas Kienast commented on patch set 5 09/25/24, 13:34
drag-uploader.ts:775ReplyDone -
Benjamin Franzke voted on patch set 5 CR +1 V +1 09/25/24, 19:19
-
Benni Mack voted on patch set 5 CR +1 V +1 09/26/24, 09:44
-
Benjamin Franzke voted on patch set 5 CR +2 V +2 09/26/24, 09:47
-
Benjamin Franzke merged patch set 6 09/26/24, 09:48
drag-uploader.ts:631