Review main Merged

86294[TASK] Use progress bar component in file upload

Andreas Kienast CR +2 V +2 Normal +34 −114 updated 09/26/24, 09:48

Commit message

This commit replaces the custom-tailored upload progress bar with the
progress bar component shipped with TYPO3. In the same run, custom CSS
is not required anymore and therefore removed.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 1620

  1. Andreas Kienast uploaded patch set 1 09/24/24, 08:39

  2. core-ci voted on patch set 1 V +1 09/24/24, 08:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66481

  3. Benjamin Franzke uploaded patch set 2 V +1 09/24/24, 09:50

  4. Benjamin Franzke commented on patch set 2 09/24/24, 09:50

    drag-uploader.ts:631

    The table-row size was increased during upload (due to bar+label), which results in a size-change after the progress bar is removed and the file metadata is displayed). I've now applied is slighter smaller padding to the progress col

    drag-uploader.ts:764

    This should probably some label like: `Uploading… 56%`

    drag-uploader.ts:778

    label: `Upload complete.`?
  5. Benjamin Franzke uploaded patch set 3 CR +1 V +1 09/24/24, 09:51

  6. core-ci voted on patch set 3 V +1 09/24/24, 09:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66485

  7. Andreas Kienast commented on patch set 3 09/24/24, 10:13

    drag-uploader.ts:775

    The label says "Upload complete! Filelist reloading..." but the file list does not reload automatically.
  8. Benjamin Franzke commented on patch set 3 CR 0 V 0 09/24/24, 10:24

    drag-uploader.ts:775 Reply

    ack, I was fine with it, because it had some delay until it showed the metadata. But a new label would be even better 👍
  9. Andreas Kienast uploaded patch set 4 V +1 09/24/24, 11:38

  10. core-ci voted on patch set 4 V +1 09/24/24, 11:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66490

  11. Andreas Kienast commented on patch set 4 09/24/24, 11:44

    drag-uploader.ts:775 Reply

    I hope the approach I just pushed is better.
  12. Benjamin Franzke commented on patch set 4 09/25/24, 06:31

    locallang_core.xlf:691

    resname is outdated
  13. Andreas Kienast commented on patch set 4 CR -1 09/25/24, 06:48

    locallang_core.xlf:691 Reply

    Acknowledged
  14. Andreas Kienast uploaded patch set 5 CR -1 V +1 09/25/24, 06:49

  15. core-ci voted on patch set 5 V +1 09/25/24, 06:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66541

  16. Andreas Kienast commented on patch set 5 09/25/24, 13:34

    drag-uploader.ts:775 Reply

    Done
  17. Benjamin Franzke voted on patch set 5 CR +1 V +1 09/25/24, 19:19

  18. Benni Mack voted on patch set 5 CR +1 V +1 09/26/24, 09:44

  19. Benjamin Franzke voted on patch set 5 CR +2 V +2 09/26/24, 09:47

  20. Benjamin Franzke merged patch set 6 09/26/24, 09:48