Review main Merged

86295[BUGFIX] Allow native enums as select-vh property

Achim Fritz CR +2 V +2 Normal +131 −1 updated 09/25/24, 09:21

Commit message

Passing native enmus as property to a select-vh
should return the enum value instead of trying
to cast it to string

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
    • Achim Fritz +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
    • Achim Fritz +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 1216

  1. Achim Fritz uploaded patch set 1 09/24/24, 12:08

  2. Benni Mack updated the commit message in patch set 2 09/24/24, 12:10

  3. core-ci voted on patch set 1 V +1 09/24/24, 12:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66491

  4. core-ci voted on patch set 2 V +1 09/24/24, 12:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66492

  5. Oli Bartsch uploaded patch set 3 V +1 09/24/24, 13:16

  6. Oli Bartsch voted on patch set 3 CR +1 V +1 09/24/24, 13:17

  7. core-ci voted on patch set 3 V +1 09/24/24, 13:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66498

  8. Garvin Hicking voted on patch set 3 CR +1 V +1 09/24/24, 15:49

  9. Oli Bartsch voted on patch set 3 V 0 CR -1 09/24/24, 20:13

  10. Oli Bartsch uploaded patch set 4 CR +1 V +1 09/24/24, 20:21

  11. Oli Bartsch voted on patch set 4 CR +1 V +1 09/24/24, 20:21

  12. core-ci voted on patch set 4 V +1 09/24/24, 20:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66524

  13. Garvin Hicking voted on patch set 4 CR +1 V +1 09/25/24, 07:16

  14. Achim Fritz voted on patch set 4 CR +1 V +1 09/25/24, 07:59

  15. Oli Bartsch voted on patch set 4 CR +2 V +2 09/25/24, 09:21

  16. Oli Bartsch merged patch set 5 09/25/24, 09:21