Review main Merged

86297[TASK] Implement context-aware scaffold with theme support

Benjamin Kott CR +2 V +2 Expert +722 −645 updated 09/26/24, 12:54

Commit message

The scaffold is now context-aware and automatically
adapts to light and dark color schemes based on
user preferences. A new user option called "theme"
has been introduced, offering two initial themes:
modern and classic.

The modern theme fully adjusts to the user's system
preferences, while the classic theme only adapts the
scaffold contents, keeping the module menu and topbar
consistently dark.

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
    • Benjamin Franzke +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benjamin Kott +2
    • Benjamin Franzke +1
    • Frank Nägler +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 56

Show 36 more files

Review log 2644

Show 1119 earlier messages
  1. Benjamin Kott uploaded patch set 1 09/24/24, 13:09

  2. Andreas Kienast commented on patch set 1 09/24/24, 13:23

    _modulemenu.scss:162

    This is used in `typo3/sysext/install/Resources/Private/Templates/Layout/MainLayout.html`
  3. Benjamin Kott uploaded patch set 2 09/24/24, 15:03

  4. core-ci voted on patch set 2 V -1 09/24/24, 15:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66503

  5. Benjamin Kott uploaded patch set 3 V -1 09/25/24, 07:39

  6. core-ci voted on patch set 3 V -1 09/25/24, 07:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66547

  7. Benjamin Kott uploaded patch set 4 V -1 09/25/24, 07:47

  8. core-ci voted on patch set 4 V -1 09/25/24, 07:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66548

  9. Benjamin Kott uploaded patch set 5 V -1 09/25/24, 08:06

  10. core-ci voted on patch set 5 V -1 09/25/24, 08:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66553

  11. Benjamin Kott uploaded patch set 6 V -1 09/25/24, 09:32

  12. core-ci voted on patch set 6 V -1 09/25/24, 09:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66563

  13. Benjamin Kott uploaded patch set 7 V -1 09/25/24, 11:46

  14. Benjamin Kott uploaded patch set 8 09/25/24, 11:56

  15. core-ci voted on patch set 7 V -1 09/25/24, 11:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66580

  16. Benjamin Kott uploaded patch set 9 09/25/24, 12:03

  17. core-ci voted on patch set 8 V -1 09/25/24, 12:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66582

  18. core-ci voted on patch set 9 V +1 09/25/24, 12:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66584

  19. Benjamin Kott uploaded patch set 10 V +1 09/25/24, 13:35

  1. core-ci voted on patch set 10 V +1 09/25/24, 13:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66589

  2. Benjamin Kott uploaded patch set 11 V +1 09/25/24, 14:11

  3. core-ci voted on patch set 11 V +1 09/25/24, 14:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66590

  4. Benjamin Kott uploaded patch set 12 V +1 09/25/24, 14:25

  5. core-ci voted on patch set 12 V +1 09/25/24, 14:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66592

  6. Benjamin Kott uploaded patch set 13 V +1 09/26/24, 09:24

  7. core-ci voted on patch set 13 V +1 09/26/24, 09:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66654

  8. Benjamin Kott uploaded patch set 14 V +1 09/26/24, 09:38

  9. core-ci voted on patch set 14 V +1 09/26/24, 09:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66656

  10. Benjamin Kott uploaded patch set 15 V +1 09/26/24, 10:27

  11. core-ci voted on patch set 15 V +1 09/26/24, 10:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66663

  12. Benjamin Kott uploaded patch set 16 V +1 09/26/24, 10:39

  13. core-ci voted on patch set 16 V +1 09/26/24, 10:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66666

  14. Benjamin Kott uploaded patch set 17 V +1 09/26/24, 10:54

  15. core-ci voted on patch set 17 V +1 09/26/24, 10:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66667

  16. Benjamin Kott uploaded patch set 18 V +1 09/26/24, 11:49

  17. Benjamin Franzke commented on patch set 18 09/26/24, 11:52

    _modulemenu.scss:162 Reply

    Done
  18. core-ci voted on patch set 18 V +1 09/26/24, 11:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66669

  19. Benjamin Kott updated the commit message in patch set 19 V +1 09/26/24, 11:58

  20. core-ci voted on patch set 19 V +1 09/26/24, 12:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66671

  21. Benjamin Franzke voted on patch set 19 CR +1 V +1 09/26/24, 12:09

  22. Frank Nägler voted on patch set 19 V +1 09/26/24, 12:15

  23. Andreas Kienast voted on patch set 19 CR +1 V +1 09/26/24, 12:54

  24. Benjamin Kott voted on patch set 19 CR +2 V +2 09/26/24, 12:54

  25. Benjamin Kott merged patch set 20 09/26/24, 12:54