Review main Merged

86298[TASK] Refactor MediaViewHelperTest in fluid

Karsten Nowak CR +2 V +2 Easy +11 −8 updated 09/24/24, 15:35

Commit message

Other ViewHelper tests (e.g. ImageViewHelperTest) are already changed
to use a real Fluid TemplateView for testing.

Review

  • Code review CR +2 Done
    • Simon Praetorius +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Simon Praetorius +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 811

  1. Karsten Nowak uploaded patch set 1 09/24/24, 15:00

  2. Karsten Nowak updated the commit message in patch set 2 09/24/24, 15:07

  3. core-ci voted on patch set 1 V +1 09/24/24, 15:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66501

  4. core-ci voted on patch set 2 V +1 09/24/24, 15:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66505

  5. Garvin Hicking commented on patch set 2 09/24/24, 15:22

    MediaViewHelperTest.php:42

    I think this should be f:media here to test the fall-through?
  6. Karsten Nowak uploaded patch set 3 V +1 09/24/24, 15:25

  7. Karsten Nowak commented on patch set 3 09/24/24, 15:28

    MediaViewHelperTest.php:42 Reply

    Sure, you are right
  8. core-ci voted on patch set 3 V +1 09/24/24, 15:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66509

  9. Garvin Hicking commented on patch set 3 CR +1 V +1 09/24/24, 15:34

    lgtm, thanks!

    MediaViewHelperTest.php:42 Reply

    Done
  10. Simon Praetorius voted on patch set 3 CR +2 V +2 09/24/24, 15:35

  11. Simon Praetorius merged patch set 4 09/24/24, 15:35