Review main Merged

86299[TASK] Use TCASchema for page view components

Oli Bartsch CR +2 V +2 Normal +79 −46 updated 10/04/24, 14:21

Commit message

Components providing functionality for the page
view (page module) are now using the TCASchema
instead of accessing $GLOBALS['TCA'].

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Benni Mack +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Benni Mack +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 1014

  1. Oli Bartsch uploaded patch set 1 09/24/24, 15:02

  2. Benni Mack commented on patch set 1 09/24/24, 15:10

    TcaSchema.php:105

    I suggest to just check for enablecolumns as array
  3. core-ci voted on patch set 1 V -1 09/24/24, 15:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66502

  4. Oli Bartsch uploaded patch set 2 V -1 09/24/24, 15:23

  5. Oli Bartsch commented on patch set 2 09/24/24, 15:23

    TcaSchema.php:105 Reply

    Done
  6. core-ci voted on patch set 2 V +1 09/24/24, 15:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66508

  7. Oli Bartsch uploaded patch set 3 V +1 09/25/24, 06:43

  8. core-ci voted on patch set 3 V +1 09/25/24, 06:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66540

  9. Oli Bartsch rebased onto patch set 4 V +1 10/01/24, 14:44

  10. core-ci voted on patch set 4 V +1 10/01/24, 14:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66902

  11. Benni Mack voted on patch set 4 CR +1 V +1 10/02/24, 13:54

  12. Simon Schaufelberger voted on patch set 4 CR +1 V +1 10/04/24, 13:30

  13. Oli Bartsch voted on patch set 4 CR +2 V +2 10/04/24, 14:21

  14. Oli Bartsch merged patch set 5 10/04/24, 14:21