Review main Merged

86300[BUGFIX] Provide label_userFunc_options for label_userFunc in FlexFormValueFormatter

Oli Bartsch CR +2 V +2 Easy +1 −0 updated 09/24/24, 21:09

Commit message

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
    • Garvin Hicking +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1113

  1. Oli Bartsch uploaded patch set 1 09/24/24, 15:04

  2. core-ci voted on patch set 1 V +1 09/24/24, 15:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66504

  3. Benni Mack voted on patch set 1 CR +1 V +1 09/24/24, 15:19

  4. Garvin Hicking voted on patch set 1 CR +1 V +1 09/24/24, 15:43

  5. Georg Ringer voted on patch set 1 CR +1 V +1 09/24/24, 18:22

  6. Garvin Hicking commented on patch set 1 V 0 CR -1 09/24/24, 19:34

    FlexFormValueFormatter.php:201

    Should it be label_userFunc_options ? That one exists in TcaRecordTitle.php and BackendUtility.php.
  7. Oli Bartsch uploaded patch set 2 CR +1 V +1 09/24/24, 20:06

  8. Oli Bartsch commented on patch set 2 09/24/24, 20:06

    FlexFormValueFormatter.php:201 Reply

    Totally right. Thanks!!
  9. core-ci voted on patch set 2 V +1 09/24/24, 20:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66523

  10. Garvin Hicking voted on patch set 2 CR +1 V +1 09/24/24, 20:20

  11. Georg Ringer voted on patch set 2 CR +1 V +1 09/24/24, 20:26

  12. Oli Bartsch voted on patch set 2 CR +2 V +2 09/24/24, 21:09

  13. Oli Bartsch merged patch set 3 09/24/24, 21:09