Review main Merged

86303[BUGFIX] Ensure existing preview popup windows are focussed

Garvin Hicking CR +2 V +2 Easy +2 −1 updated 11/04/24, 18:08

Commit message

When a frontend preview is executed from within the backend,
a window/tab will open with that location. Another preview
will re-use that existing window/tab and only reload its
location.

However, a `focus()` call was only issued for fresh tabs,
and existing tabs would not necessarily receive focus.
To ensure this accross browsers, the `focus()` is
specifically addressed.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 810

  1. Garvin Hicking uploaded patch set 1 09/24/24, 19:18

  2. core-ci voted on patch set 1 V +1 09/24/24, 19:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66517

  3. Benni Mack updated the commit message in patch set 2 V +1 10/18/24, 13:55

  4. Benni Mack rebased onto patch set 3 11/04/24, 14:52

  5. Andreas Kienast voted on patch set 3 CR +1 V +1 11/04/24, 14:52

  6. core-ci voted on patch set 3 V +1 11/04/24, 14:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69040

  7. Benjamin Franzke commented on patch set 3 V -1 11/04/24, 16:43

    Can not reproduce this bug in chrome or firefox. Are we sure this is still an issue in current browsers? Rechecking the issue I see you asked the same in https://forge.typo3.org/issues/105104#note-4
  8. Benjamin Franzke commented on patch set 3 V 0 11/04/24, 16:47

    Reply

    hm.. so `View page` via context menu was not affected, only "Page overview" "view" Button. Resetting my vote, but still seems strange that different actions seem to use different codepaths
  9. Benjamin Franzke voted on patch set 3 CR +2 V +2 11/04/24, 16:56

  10. Benjamin Franzke merged patch set 4 11/04/24, 18:08