Review main Merged

86305[BUGFIX] Avoid RTE css prefixing in nested selectors

Benjamin Franzke CR +2 V +2 Normal +40 −12 updated 09/25/24, 10:03

Commit message

Nested selectors – as in `:has()`, `:where` and `:is()` – act
relative to the current selector context, that means an absolute
prefix will break the relative context.

Adapt the css-prefixer to stop node traversal for nested
selectors.

@types/css-tree is updated in order for csstree.walk.skip
to be declared.

Executed commands:
  npm install --save-dev @types/css-tree@2.3.8

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 710

  1. Benjamin Franzke uploaded patch set 1 09/25/24, 06:12

  2. core-ci voted on patch set 1 V -1 09/25/24, 06:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66538

  3. Benjamin Franzke uploaded patch set 2 V -1 09/25/24, 06:23

  4. core-ci voted on patch set 2 V +1 09/25/24, 06:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66539

  5. Garvin Hicking commented on patch set 2 CR +1 V +1 09/25/24, 06:56

    Works with my tests! 😊
  6. Andreas Kienast updated the commit message in patch set 3 CR +1 V +1 09/25/24, 07:21

  7. core-ci voted on patch set 3 V +1 09/25/24, 07:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66542

  8. Garvin Hicking voted on patch set 3 CR +1 V +1 09/25/24, 09:09

  9. Andreas Kienast voted on patch set 3 CR +2 V +2 09/25/24, 09:54

  10. Andreas Kienast merged patch set 4 09/25/24, 10:03