Review main Merged

86307[BUGFIX] Properly handle form state

Oli Bartsch CR +2 V +2 Normal +51 −60 updated 10/01/24, 13:40

Commit message

A couple for form elements, such as checkboxes
and inline elements used the `form-legend` class
on a <legend> instead of `form-label` on a `<label>`
to describe the corresponding form field.

This patch now unifies this, merging the
special `form-legend` together with the existing
`form-label` class. This also leads to the same
migration done for the corresponding JS selector
class `.t3js-formengine-legend`.

On changing a file, inline or site language
element the `has-change` class is now also
properly added again, using the corresponding
FormEngine API.

This API however is changed to add the class
not to a container but to the corresponding fields
and their associated label to prevent wrong
inheritance of those  styles, which occurred e.g.
in inline elements.

Finally, a possible null pointer exception is
fixed by using the remove() API to remove a
record container. The previously approach
seemed to be vulnerable to timing issues.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Andreas Kienast +1
    • Benjamin Kott +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Andreas Kienast +1
    • Benjamin Kott +1
    • core-ci +1 CI

Issues 1

Files 26

Show 6 more files

Review log 2537

Show 912 earlier messages
  1. Oli Bartsch uploaded patch set 1 09/25/24, 07:50

  2. core-ci voted on patch set 1 V +1 09/25/24, 07:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66549

  3. Oli Bartsch uploaded patch set 2 V +1 09/25/24, 10:06

  4. core-ci voted on patch set 2 V -1 09/25/24, 10:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66568

  5. core-ci voted on patch set 2 V +1 09/25/24, 10:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66568

  6. Benjamin Kott commented on patch set 2 CR -2 09/25/24, 10:51

    we need to talk
  7. Oli Bartsch uploaded patch set 3 V +1 09/25/24, 14:21

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  8. Oli Bartsch commented on patch set 3 09/25/24, 14:24

    Reply

    Great to talk to you. Please revisit this change :)
  9. Benjamin Kott voted on patch set 3 CR +1 V +1 09/25/24, 14:35

  10. Andreas Kienast updated the commit message in patch set 4 CR +1 V +1 09/25/24, 14:35

  11. Andreas Kienast updated the commit message in patch set 5 09/25/24, 14:36

  12. Benjamin Kott voted on patch set 5 CR +1 V +1 09/25/24, 14:36

  1. core-ci voted on patch set 3 V -1 09/25/24, 14:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66591

  2. core-ci voted on patch set 5 V -1 09/25/24, 14:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66596

  3. Oli Bartsch uploaded patch set 6 CR +1 V +1 09/25/24, 14:49

  4. core-ci voted on patch set 6 V +1 09/25/24, 14:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66597

  5. Oli Bartsch uploaded patch set 7 V +1 09/25/24, 20:28

  6. Oli Bartsch commented on patch set 7 09/25/24, 20:29

    form-engine.ts:80

    Drive by fix of a non working selector..
  7. core-ci voted on patch set 7 V +1 09/25/24, 20:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66618

  8. Benjamin Kott voted on patch set 7 CR +1 V +1 09/26/24, 08:06

  9. Oli Bartsch uploaded patch set 8 CR +1 V +1 09/28/24, 09:42

  10. core-ci voted on patch set 8 V +1 09/28/24, 09:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66772

  11. Benjamin Kott voted on patch set 8 CR +1 V +1 10/01/24, 06:55

  12. Andreas Kienast updated the commit message in patch set 9 CR +1 V +1 10/01/24, 07:02

  13. Andreas Kienast voted on patch set 9 CR +1 V +1 10/01/24, 07:04

  14. core-ci voted on patch set 9 V -1 10/01/24, 07:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66875

  15. core-ci commented on patch set 9 10/01/24, 07:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66875

  16. Andreas Kienast rebased onto patch set 10 CR +1 V +1 10/01/24, 07:19

  17. Andreas Kienast voted on patch set 10 CR +1 V +1 10/01/24, 07:19

  18. core-ci voted on patch set 10 V +1 10/01/24, 07:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66878

  19. Benjamin Kott voted on patch set 10 CR +1 V +1 10/01/24, 08:36

  20. Oli Bartsch updated the commit message in patch set 11 CR +1 V +1 10/01/24, 13:16

  21. Benjamin Kott voted on patch set 11 CR +1 V +1 10/01/24, 13:17

  22. core-ci voted on patch set 11 V +1 10/01/24, 13:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66894

  23. Andreas Kienast voted on patch set 11 CR +1 V +1 10/01/24, 13:25

  24. Oli Bartsch voted on patch set 11 CR +2 V +2 10/01/24, 13:40

  25. Oli Bartsch merged patch set 12 10/01/24, 13:40