86307[BUGFIX] Properly handle form state
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Andreas Kienast +1
- Benjamin Kott +1
-
Verified V +2 Done
- Oli Bartsch +2
- Andreas Kienast +1
- Benjamin Kott +1
- core-ci +1 CI
Issues 1
Files 26
- Build/Sources/Sass/component/forms/_form-label.scss+5 −1
- Build/Sources/Sass/component/forms/_form-legend.scssdeleted+0 −10
- Build/Sources/Sass/component/forms/_form-validation.scss+4 −0
- Build/Sources/Sass/component/_form.scss+0 −1
- Build/Sources/Sass/component/_root.scss+0 −3
- Build/Sources/TypeScript/backend/form-engine/container/files-control-container.ts+3 −3
- Build/Sources/TypeScript/backend/form-engine/container/inline-control-container.ts+4 −4
- Build/Sources/TypeScript/backend/form-engine/container/site-language-container.ts+3 −3
- Build/Sources/TypeScript/backend/form-engine/element/table-wizard-element.ts+3 −3
- Build/Sources/TypeScript/backend/form-engine-review.ts+1 −6
- Build/Sources/TypeScript/backend/form-engine-validation.ts+4 −3
- Build/Sources/TypeScript/backend/form-engine.ts1+1 −1
- typo3/sysext/backend/Classes/Form/Container/AbstractContainer.php+1 −1
- typo3/sysext/backend/Classes/Form/Element/AbstractFormElement.php+1 −1
- typo3/sysext/backend/Classes/Form/Element/TablePermissionElement.php+1 −1
- typo3/sysext/backend/Classes/Form/FieldWizard/LocalizationStateSelector.php+1 −1
- typo3/sysext/backend/Resources/Public/Css/backend.css+7 −7
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine/container/files-control-container.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine/container/inline-control-container.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine/container/site-language-container.js+1 −1
Show 6 more files
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine/element/table-wizard-element.js+3 −3
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine-review.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine-validation.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine.js+1 −1
- typo3/sysext/core/Tests/Acceptance/Application/FormEngine/NullPlaceholderCest.php+2 −1
- typo3/sysext/lowlevel/Classes/Controller/DatabaseIntegrityController.php+1 −1
Review log 2537
Show 912 earlier messages
-
Oli Bartsch uploaded patch set 1 09/25/24, 07:50
-
core-ci voted on patch set 1 V +1 09/25/24, 07:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66549
-
Oli Bartsch uploaded patch set 2
V +109/25/24, 10:06 -
core-ci voted on patch set 2 V -1 09/25/24, 10:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66568
-
core-ci voted on patch set 2 V +1 09/25/24, 10:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66568
-
Benjamin Kott commented on patch set 2 CR -2 09/25/24, 10:51
we need to talk -
Oli Bartsch uploaded patch set 3
V +109/25/24, 14:21Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
Oli Bartsch commented on patch set 3 09/25/24, 14:24
Reply
Great to talk to you. Please revisit this change :) -
Benjamin Kott voted on patch set 3 CR +1 V +1 09/25/24, 14:35
-
Andreas Kienast updated the commit message in patch set 4
CR +1V +109/25/24, 14:35 -
Andreas Kienast updated the commit message in patch set 5 09/25/24, 14:36
-
Benjamin Kott voted on patch set 5 CR +1 V +1 09/25/24, 14:36
-
core-ci voted on patch set 3 V -1 09/25/24, 14:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66591
-
core-ci voted on patch set 5 V -1 09/25/24, 14:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66596
-
Oli Bartsch uploaded patch set 6
CR +1V +109/25/24, 14:49 -
core-ci voted on patch set 6 V +1 09/25/24, 14:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66597
-
Oli Bartsch uploaded patch set 7
V +109/25/24, 20:28 -
Oli Bartsch commented on patch set 7 09/25/24, 20:29
form-engine.ts:80Drive by fix of a non working selector.. -
core-ci voted on patch set 7 V +1 09/25/24, 20:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66618
-
Benjamin Kott voted on patch set 7 CR +1 V +1 09/26/24, 08:06
-
Oli Bartsch uploaded patch set 8
CR +1V +109/28/24, 09:42 -
core-ci voted on patch set 8 V +1 09/28/24, 09:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66772
-
Benjamin Kott voted on patch set 8 CR +1 V +1 10/01/24, 06:55
-
Andreas Kienast updated the commit message in patch set 9
CR +1V +110/01/24, 07:02 -
Andreas Kienast voted on patch set 9 CR +1 V +1 10/01/24, 07:04
-
core-ci voted on patch set 9 V -1 10/01/24, 07:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66875
-
core-ci commented on patch set 9 10/01/24, 07:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66875
-
Andreas Kienast rebased onto patch set 10
CR +1V +110/01/24, 07:19 -
Andreas Kienast voted on patch set 10 CR +1 V +1 10/01/24, 07:19
-
core-ci voted on patch set 10 V +1 10/01/24, 07:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66878
-
Benjamin Kott voted on patch set 10 CR +1 V +1 10/01/24, 08:36
-
Oli Bartsch updated the commit message in patch set 11
CR +1V +110/01/24, 13:16 -
Benjamin Kott voted on patch set 11 CR +1 V +1 10/01/24, 13:17
-
core-ci voted on patch set 11 V +1 10/01/24, 13:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66894
-
Andreas Kienast voted on patch set 11 CR +1 V +1 10/01/24, 13:25
-
Oli Bartsch voted on patch set 11 CR +2 V +2 10/01/24, 13:40
-
Oli Bartsch merged patch set 12 10/01/24, 13:40