86313[BUGFIX] Properly evaluate EXT:indexed_search restriction by mediaType
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Stefan Bürk +1
-
Verified V +2 Done
- Benni Mack +2
- core-ci +1 CI
Issues 3
Files 2
Review log 1015
-
Garvin Hicking commented on patch set 1 09/24/24, 18:58
Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/indexed_search/Classes/Domain/Repository/IndexSearchRepository.php * typo3/sysext/indexed_search/Tests/Functional/IndexSearchRepositoryTest.php -
core-ci voted on patch set 1 V -1 09/24/24, 19:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66514
-
Garvin Hicking uploaded patch set 2
V -109/24/24, 19:07Address merge conflict -
Garvin Hicking commented on patch set 2 09/24/24, 19:08
Backport note: Several differences due to not being an ENUM in v12. Also slight functional difference because values like "-189" and "189" are passed through, only in v13 the ENUM restricts this. But it's escaped like a file extension, should not matter. -
core-ci voted on patch set 2 V +1 09/24/24, 19:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66516
-
Garvin Hicking uploaded patch set 3
V +109/25/24, 07:36backport code review -
core-ci voted on patch set 3 V -1 09/25/24, 07:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66545
-
Garvin Hicking uploaded patch set 4
V -109/25/24, 09:23CGL -
core-ci voted on patch set 4 V +1 09/25/24, 09:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66562
-
Garvin Hicking uploaded patch set 5
V +109/30/24, 10:13Use different testing approach -
core-ci voted on patch set 5 V +1 09/30/24, 10:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66850
-
Garvin Hicking marked it ready for review 10/11/24, 07:13
-
Stefan Bürk voted on patch set 5 CR +1 10/14/24, 08:24
-
Benni Mack commented on patch set 5 CR +2 V +2 10/15/24, 05:20
Reply
Acknowledged -
Benni Mack merged patch set 6 10/15/24, 05:20