Review main Merged

86318[TASK] Revert "[BUGFIX] Navigate to selected page on switch of module"

Benjamin Franzke CR +2 V +2 Easy +7 −39 updated 09/25/24, 11:49

Commit message

This reverts commit 24ce70c6018b6bcd0436be68f6fbddf7e2ae1f70.

Reason for revert: The patch applied a workaround in the interpretation
of the a broken module storage state, instead of fixing the originator
of the broken state. The page tree wrote the tree identifier instead
of the page identifier into the module state since #103043.
This
needs to be fixed in a new patch.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 67

  1. Benjamin Franzke uploaded patch set 1 09/25/24, 10:34

  2. core-ci voted on patch set 1 V +1 09/25/24, 10:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66573

  3. Andreas Kienast voted on patch set 1 CR +1 V +1 09/25/24, 10:43

  4. Oli Bartsch voted on patch set 1 CR +1 V +1 09/25/24, 11:28

  5. Benjamin Franzke voted on patch set 1 CR +2 V +2 09/25/24, 11:37

  6. Benjamin Franzke merged patch set 2 09/25/24, 11:37

  7. Ayke Halder commented on patch set 2 09/25/24, 11:49

    Unresolved

    A broken module storage state is unrelated to the patch which is going to be reverted here. The change which is going to be reverted here does not change the storage-state at all. It just uses the already existing property `storage-state.identifier` instead of `storage-state.selection`. So I do not see why this should be reverted. About: > Reason for revert: […] The page tree wrote the tree identifier instead > of the page identifier into the module state since #103043. > This needs to be fixed in a new patch. AFAIK the page tree already writes both `identifier` and `selection` into the module state. And we need both `identifier` and `selection` to be stored, as they are different for page-module - see commit message of 85288: [BUGFIX] Navigate to selected page on switch of module | https://review.typo3.org/c/Packages/TYPO3.CMS/+/85288 > Module-state-storage stores the current record-id as 'identifier' and > the page-tree-path as 'selection'. > To open a page record in module 'web' we can not use 'selection': > `<PARENT_PARENT_ID>_<PARENT_ID>_<CURRENT_ID>`. > Instead we must use 'identifier': `<CURRENT_ID>`. ---- About fixing the sometimes broken module storage-state, e.g. when some component does not correctly write `identifier`/`selection`: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85327: [BUGFIX] Select pages opened via bookmark and open-docs menu in page-tree But still this needs the patch which is going to be reverted, as the patch fixes another issue.