Review main Merged

86333[BUGFIX] Pass correct page identifier into module state storage

Benjamin Franzke CR +2 V +2 Easy +35 −3 updated 09/25/24, 12:44

Commit message

With the page tree refactoring in #103043 the page tree identifier
(which contains the underscore-separated rootline) was written into
the module state storage by accident.

This identifier was reflected into the `identifier` and `selection`
module state properties.
The `identifier` was later "fixed" by implicit module state
updates in the module frame. Note: The content frames update the active
page (not the selected!) by invoking an immediate action:

  <typo3-immediate-action
    action="TYPO3.Backend.Storage.ModuleStateStorage.update"
    …

This causes `identifier` to contain the "corrected" format, but the
`selection` property was still used the wrong, underscore-separated
rootline identifier.

Since module menu makes use of the selection (and has to, in order to
retain active user selections when switching between backend modules),
this change ensures that both `identifier` and `selection` use
the same plain identifier format, as it used to before #103043.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 2

Files 4

Review log 915

  1. Benjamin Franzke uploaded patch set 1 09/25/24, 10:04

  2. core-ci voted on patch set 1 V -1 09/25/24, 10:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66567

  3. core-ci commented on patch set 1 09/25/24, 10:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66567

  4. Benjamin Franzke uploaded patch set 2 V -1 09/25/24, 10:47

  5. core-ci voted on patch set 2 V -1 09/25/24, 10:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66574

  6. core-ci commented on patch set 2 09/25/24, 11:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66574

  7. Benjamin Franzke uploaded patch set 3 V -1 09/25/24, 11:03

  8. core-ci voted on patch set 3 V +1 09/25/24, 11:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66578

  9. Andreas Kienast voted on patch set 3 CR +1 V +1 09/25/24, 11:15

  10. Oli Bartsch voted on patch set 3 CR +1 V +1 09/25/24, 11:27

  11. Benjamin Franzke commented on patch set 3 CR -1 09/25/24, 11:29

    currently testing nightlies (because of possible test re-ordering)
  12. core-ci commented on patch set 3 09/25/24, 11:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66579

  13. Benjamin Franzke voted on patch set 3 CR +2 V +2 09/25/24, 11:38

  14. Benjamin Franzke merged patch set 4 09/25/24, 11:38

  15. Ayke Halder commented on patch set 4 09/25/24, 12:44

    State-storage is now aligned for `identifier`. Thereby `selection` is broken right now, as it might only contain an object-id instead of a tree-path.