Review main Merged

86338[BUGFIX] Auto-select tree nodes in module deeplinks

Benjamin Franzke CR +2 V +2 Hard +434 −183 updated 02/06/25, 15:35

Commit message

Select pages and folders in the respective trees when opening module
routes via shared deeplinks, topbar bookmarks or via the opendocs menu.
This also implicitly retains the current tree selection when reloading
the TYPO3 backend.

The module state handling is slightly changed to better isolate
responsibility for the tree selection states:
 * modules are allowed to update the `identifier` property
   only (reflecting the current page id or folder identifier)
 * `treeIdentifier` property is the sole domain of the
   tree components (only the tree can know, which node –
   in case nodes are mounted multiple times – is to be selected)

Various tree components are updated to prepare nodes not only during
initial load but also during runtime (in order for selection to work in
any case) and have a post-initialization check to load nodes recursively
if the currently active node (per module state storage) is not visible.

Out-of-scope for this patch:
Tree nodes can not be auto-opened if a FormEngine view is loaded
(or any other non-module backend controller) as there is no module
and tree state attached to FormEngine, therefore shared Fomengine
deeplinks currently lack module context.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 31

Show 11 more files

Review log 3561

Show 1936 earlier messages
  1. Benjamin Franzke uploaded patch set 1 09/25/24, 14:25

  2. core-ci voted on patch set 1 V +1 09/25/24, 14:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66593

  3. Benjamin Franzke uploaded patch set 2 V +1 09/25/24, 15:02

  4. core-ci voted on patch set 2 V -1 09/25/24, 15:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66599

  5. Benjamin Franzke uploaded patch set 3 V -1 09/25/24, 15:22

  6. Benjamin Franzke uploaded patch set 4 09/25/24, 15:26

  7. core-ci voted on patch set 3 V -1 09/25/24, 15:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66601

  8. core-ci voted on patch set 4 V -1 09/25/24, 15:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66602

  9. Benjamin Franzke uploaded patch set 5 V -1 09/25/24, 15:40

  10. Benjamin Franzke uploaded patch set 6 09/25/24, 15:41

  11. core-ci voted on patch set 6 V +1 09/25/24, 15:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66606

  12. Benjamin Franzke uploaded patch set 7 V +1 09/25/24, 15:54

  13. Benjamin Franzke uploaded patch set 8 09/25/24, 15:58

  14. core-ci voted on patch set 7 V +1 09/25/24, 16:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66608

  15. Benjamin Franzke uploaded patch set 9 09/25/24, 16:03

  16. core-ci voted on patch set 8 V +1 09/25/24, 16:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66610

  17. core-ci voted on patch set 9 V +1 09/25/24, 16:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66611

  18. Benjamin Franzke uploaded patch set 10 V +1 09/26/24, 07:05

  19. core-ci voted on patch set 10 V -1 09/26/24, 07:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66636

  20. Benjamin Franzke uploaded patch set 11 V -1 09/26/24, 07:44

  21. core-ci voted on patch set 11 V -1 09/26/24, 07:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66641

  22. Benjamin Franzke uploaded patch set 12 V -1 09/26/24, 07:59

  23. core-ci voted on patch set 12 V -1 09/26/24, 08:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66643

  24. Benjamin Franzke uploaded patch set 13 V -1 09/26/24, 09:32

  25. core-ci voted on patch set 13 V +1 09/26/24, 09:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66655

  26. Benjamin Franzke uploaded patch set 14 V +1 09/26/24, 10:27

  27. core-ci voted on patch set 14 V +1 09/26/24, 10:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66662

  28. Benjamin Franzke uploaded patch set 15 V +1 10/01/24, 20:27

  29. core-ci voted on patch set 15 V +1 10/01/24, 20:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66924

  30. Benjamin Franzke uploaded patch set 16 V +1 10/02/24, 07:03

  31. core-ci voted on patch set 16 V -1 10/02/24, 07:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66946

  32. Benjamin Franzke uploaded patch set 17 V -1 10/02/24, 07:23

  33. core-ci voted on patch set 17 V +1 10/02/24, 07:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66948

  34. Benjamin Franzke uploaded patch set 18 V +1 10/02/24, 08:28

  35. core-ci voted on patch set 18 V +1 10/02/24, 08:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66954

  36. Benjamin Franzke marked it work in progress 10/07/24, 09:45

  1. Benjamin Franzke uploaded patch set 19 V +1 01/13/25, 13:49

  2. core-ci voted on patch set 19 V +1 01/13/25, 13:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72352

  3. Benjamin Franzke uploaded patch set 20 V +1 01/14/25, 08:32

  4. core-ci voted on patch set 20 V -1 01/14/25, 08:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72405

  5. Benjamin Franzke uploaded patch set 21 V -1 01/14/25, 09:21

  6. core-ci voted on patch set 21 V +1 01/14/25, 09:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72411

  7. Benjamin Franzke uploaded patch set 22 V +1 01/15/25, 08:35

  8. core-ci voted on patch set 22 V +1 01/15/25, 08:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72508

  9. Benjamin Franzke uploaded patch set 23 V +1 02/04/25, 08:46

  10. core-ci voted on patch set 23 V +1 02/04/25, 08:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73471

  11. Andreas Kienast commented on patch set 23 02/05/25, 14:36

    tree-module-state.ts:13

    abstract class …Interface?

    tree-module-state.ts:23

    PhpStorm-driven-development: `moduleStateType`, `selectActiveViaRootline`, `transformModuleStateIdentifierToNodeIdentifier` and `transformNodeIdentifierToModuleStateIdentifier` are marked as unused, which is not true. Can we somehow support the IDE to avoid confusion?
  12. Andreas Kienast uploaded patch set 24 V +1 02/06/25, 09:00

  13. core-ci voted on patch set 24 V +1 02/06/25, 09:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73636

  14. Benjamin Franzke uploaded patch set 25 V +1 02/06/25, 09:35

  15. Benjamin Franzke commented on patch set 25 02/06/25, 09:35

    tree-module-state.ts:23 Reply

    better now?
  16. Benjamin Franzke uploaded patch set 26 02/06/25, 09:36

  17. Andreas Kienast uploaded patch set 27 02/06/25, 09:39

  18. Andreas Kienast commented on patch set 27 CR +1 V +1 02/06/25, 09:40

    tree-module-state.ts:13 Reply

    Done

    tree-module-state.ts:23 Reply

    Done
  19. Andreas Kienast commented on patch set 27 02/06/25, 09:40

    tree-module-state.ts:13 Reply

    Done

    tree-module-state.ts:23 Reply

    Done
  20. core-ci voted on patch set 25 V +1 02/06/25, 09:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73640

  21. core-ci voted on patch set 26 V +1 02/06/25, 09:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73641

  22. core-ci voted on patch set 27 V +1 02/06/25, 09:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73642

  23. Benni Mack voted on patch set 27 CR +1 V +1 02/06/25, 12:29

  24. Benjamin Franzke voted on patch set 27 CR +2 V +2 02/06/25, 15:19

  25. Benjamin Franzke merged patch set 28 02/06/25, 15:35