Review main Merged

86339[BUGFIX] Use correct `list_frame` accessor in color scheme manager

Andreas Kienast CR +2 V +2 Easy +2 −2 updated 09/25/24, 14:37

Commit message

The color scheme manager now uses `window.frames.list_frame` to access
the content frame, including a null coalesce chaining operator.

The previously used `document.list_frame` is Webkit/Blink specific and
doesn't work in Firefox.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Andreas Nedbal +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Andreas Nedbal +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 56

  1. Andreas Kienast uploaded patch set 1 09/25/24, 14:25

  2. Benjamin Franzke voted on patch set 1 CR +1 V +1 09/25/24, 14:28

  3. Andreas Nedbal voted on patch set 1 CR +1 V +1 09/25/24, 14:31

  4. core-ci voted on patch set 1 V +1 09/25/24, 14:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66594

  5. Andreas Kienast voted on patch set 1 CR +2 V +2 09/25/24, 14:37

  6. Andreas Kienast merged patch set 2 09/25/24, 14:37