Review main Merged

86340[BUGFIX] Show/hide upload progress and info container in empty folder

Sébastien Delcroix CR +2 V +2 Easy +5 −5 updated 10/02/24, 23:01

Commit message

Since introduction of "tile view" mode for filelist module in v12, the
progress bars were non longer visible when uploading files in an empty
folder, because the visibility of the empty parent (filelist) table
no longer toggles.

For v12, it was due to a wrong class selector
(`.t3-filelist-table-container` has been renamed to
`.t3-filelist-container`).

For main, in addition to this change, jQuery has been removed and during
this, the behaviour of the uploading files progress has changed.
Now the table that will contain the uploading files progress is created
"on the fly" and then set to hidden until upload starts.
It works fine for "tile view" but not for "list view" because this
table exists even if the folder is empty and does not have a "hidden"
attribute that serves visibility toggling.

This patch fixes these two cases separately regarding the branch :

* for v12 : just adapts the class selector
* for main : only render the table if folder is not empty

Consequently, the uploading files progress in empty folder is now
displayed in the same container for both "view" modes.
And in "list view" in a folder containing items, the progress is
displayed in the existing filelist.

This patch also fixes the hiding of the info container when the upload
starts.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Guido Schmechel +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Guido Schmechel +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1420

  1. Sébastien Delcroix uploaded patch set 1 09/26/24, 06:52

  2. core-ci voted on patch set 1 V -1 09/26/24, 06:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66635

  3. Sébastien Delcroix uploaded patch set 2 09/26/24, 07:07

    Copied Votes: * Verified-1 (copy condition: "**changekind:NO_CHANGE**")
  4. core-ci voted on patch set 2 V -1 09/26/24, 07:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66637

  5. Sébastien Delcroix uploaded patch set 3 V -1 09/26/24, 07:20

  6. core-ci voted on patch set 3 V -1 09/26/24, 07:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66638

  7. Sébastien Delcroix uploaded patch set 4 V -1 09/26/24, 11:56

  8. core-ci voted on patch set 4 V +1 09/26/24, 12:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66670

  9. Sébastien Delcroix uploaded patch set 5 V +1 09/26/24, 12:03

  10. core-ci voted on patch set 5 V +1 09/26/24, 12:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66672

  11. Sébastien Delcroix commented on patch set 5 09/26/24, 14:57

    While working on this, I've noticed that the div.t3-filelist-info-container is still visible after upload. I may fix this within this patch too.
  12. Sébastien Delcroix uploaded patch set 6 V +1 09/27/24, 18:57

  13. Sébastien Delcroix commented on patch set 6 09/27/24, 18:58

    Reply

    Done
  14. core-ci voted on patch set 6 V +1 09/27/24, 19:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66758

  15. Nikita Hovratov commented on patch set 6 V +1 09/30/24, 07:26

    List.html:156

    Could you also hide the clipboard for empty folders as drive-by change? So it aligns with the condition above.
  16. Nikita Hovratov commented on patch set 6 CR +1 09/30/24, 07:30

    List.html:156 Reply

    nvm, I think the condition should vanish completely, as the page reloads anyway if you insert something from the clipboard.
  17. Garvin Hicking voted on patch set 6 CR +1 V +1 09/30/24, 08:26

  18. Guido Schmechel voted on patch set 6 CR +1 V +1 10/02/24, 22:37

  19. Garvin Hicking voted on patch set 6 CR +2 V +2 10/02/24, 23:00

  20. Garvin Hicking merged patch set 7 10/02/24, 23:01