Review main Merged

86341[BUGFIX] Allow saving user preferences with removed password field

Peter Kraume CR +2 V +2 Easy +1 −1 updated 09/27/24, 07:50

Commit message

It is possible to disable the backend user password field with
User TSConfig: `setup.fields.password.disabled = 1`

In this case the form value 'password' is not be submitted at all
and missing undefined array key caused PHP warnings (resulting in
errors) which prevented the persistence of user preferences.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1317

  1. Peter Kraume uploaded patch set 1 09/26/24, 07:48

  2. core-ci voted on patch set 1 V +1 09/26/24, 07:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66642

  3. Mathias Brodala commented on patch set 1 09/26/24, 07:55

    SetupModuleController.php:236

    How about this: (string)($be_user_data['password'] ?? '') !== '' (Not exactly sure why the string cast is here.)
  4. Garvin Hicking updated the commit message in patch set 2 V +1 09/26/24, 08:43

  5. core-ci voted on patch set 2 V +1 09/26/24, 08:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66647

  6. Peter Kraume uploaded patch set 3 V +1 09/26/24, 10:33

  7. Peter Kraume commented on patch set 3 09/26/24, 10:33

    SetupModuleController.php:236 Reply

    Done
  8. core-ci voted on patch set 3 V +1 09/26/24, 10:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66664

  9. Garvin Hicking voted on patch set 3 CR +1 V +1 09/26/24, 13:02

  10. Georg Ringer voted on patch set 3 CR +1 V +1 09/27/24, 05:54

  11. Benjamin Franzke commented on patch set 3 CR -1 09/27/24, 06:46

    will adapt commit message
    this confused me, because there is not exception. It is actually an error (PHP warning with respective error level).
    let's say "disabled"
  12. Benjamin Franzke uploaded patch set 4 CR +1 V +1 09/27/24, 06:55

  13. Benjamin Franzke commented on patch set 4 09/27/24, 06:55

    Reply

    Done

    Reply

    Done
  14. core-ci voted on patch set 4 V +1 09/27/24, 07:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66706

  15. Garvin Hicking voted on patch set 4 CR +1 V +1 09/27/24, 07:04

  16. Benjamin Franzke voted on patch set 4 CR +2 V +2 09/27/24, 07:50

  17. Benjamin Franzke merged patch set 5 09/27/24, 07:50