Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.

Review main Work in progress Orphaned

86342[WIP][TASK] Increase database API tests

Stefan Bürk CR 0 V 0 Normal +111 −0 updated 04/21/26, 15:15

Commit message

Database related API has the one or other unit
test using shared expectationg by using mocks.
That does not reflect the real world and may
not detect issues within the API if not used
otherwise within the TYPO3 core itself along
with tests for these places.

This change adds more tests for database API
related methods to provide examples and really
ensure working state.

Added tests for:

* `ExpressionBuilder->in()` with string value-list
  using `QueryBuilder->createNamedParameter()`
* ...

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 3
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/42/86342/3 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/42/86342/3 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V 0 Needs a vote

Files 2

Review log 79

  1. Stefan Bürk uploaded patch set 1 09/26/24, 08:18

  2. core-ci voted on patch set 1 V +1 09/26/24, 08:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66644

  3. Lina Wolf commented on patch set 1 09/26/24, 08:41

    I think it is helpful to have tests for this. Not an expert in the area though.
  4. Garvin Hicking commented on patch set 1 CR +1 V +1 09/26/24, 08:59

    Good one!!
  5. Stefan Bürk uploaded patch set 2 CR +1 V +1 09/26/24, 09:10

  6. Garvin Hicking voted on patch set 2 CR +1 V +1 09/26/24, 09:14

  7. core-ci voted on patch set 2 V +1 09/26/24, 09:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66651

  8. Oliver Hader updated the commit message in patch set 3 CR +1 V +1 10/18/24, 14:03

  9. Benni Mack marked it work in progress 04/21/26, 15:15