Review main Merged

86344[BUGFIX] Immediately apply color scheme and theme changes in user setup

Benjamin Franzke CR +2 V +2 Normal +149 −74 updated 09/27/24, 08:02

Commit message

The setup module controller is now triggering a color scheme or theme
update whenever the user changed the respective value.

The color-scheme manager is renamed into user settings manager and
adapted to take the sole domain of communicating (via broadcast) with
other TYPO3 browser tabs, so that both "color-theme-switch" (toolbar)
and setup-module (color scheme/theme options) do persist settings and
trigger the user-settings-manager for applying and broadcasting the
update via an event.

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benjamin Kott +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 10

Review log 2130

Show 45 earlier messages
  1. Benjamin Franzke uploaded patch set 1 09/26/24, 08:48

  2. Benjamin Franzke uploaded patch set 2 09/26/24, 08:50

  3. Benjamin Franzke uploaded patch set 3 09/26/24, 08:51

  4. core-ci voted on patch set 1 V +1 09/26/24, 08:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66648

  5. Frank Nägler commented on patch set 3 09/26/24, 08:57

    With this patch, the hint "Notice! In order to activate most of these changes, please reload the backend (eg. logout and login again)." after saving can be removed, right?
  1. core-ci voted on patch set 3 V +1 09/26/24, 08:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66650

  2. Andreas Kienast commented on patch set 3 09/26/24, 09:07

    Reply

    That's a tough one. This message is controlled by a flag that becomes `true` if backend user UC has changed, which is true in this case.
  3. Benjamin Franzke commented on patch set 3 09/26/24, 09:09

    Reply

    We should at least try to (but not within this patch). This notice existed at least since 2004: https://github.com/TYPO3/typo3/commit/109b1924c4180883c9ed46c97e3107a38dc18fd6 we need to track-down what's not automatically updated these days.. If there is nothing left, yes, then that can be removed. Toolbar and pagetree receive updates, so there shouldn't be much left.
  4. Frank Nägler commented on patch set 3 09/26/24, 09:12

    Reply

    okay, was just an idea.
  5. Benjamin Franzke commented on patch set 3 09/26/24, 09:15

    Reply

    I found one left-over: backendTitleFormat (not updated directly, currently needs backend refresh)
  6. Benjamin Franzke uploaded patch set 4 V +1 09/26/24, 09:16

  7. core-ci voted on patch set 4 V +1 09/26/24, 09:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66653

  8. Andreas Kienast voted on patch set 4 CR +1 V +1 09/26/24, 09:24

  9. Benjamin Franzke uploaded patch set 5 CR +1 V +1 09/26/24, 17:02

  10. core-ci voted on patch set 5 V +1 09/26/24, 17:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66678

  11. Benjamin Franzke uploaded patch set 6 V +1 09/26/24, 17:21

  12. Benjamin Franzke uploaded patch set 7 09/26/24, 17:22

  13. core-ci voted on patch set 7 V -1 09/26/24, 17:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66681

  14. core-ci voted on patch set 7 V +1 09/26/24, 17:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66681

  15. Andreas Kienast voted on patch set 7 CR +1 V +1 09/27/24, 05:50

  16. Benjamin Franzke commented on patch set 7 09/27/24, 07:08

    user-settings-manager.ts:18

    colorSchemeSwitch
  17. Benjamin Franzke uploaded patch set 8 CR +1 V +1 09/27/24, 07:21

  18. Benjamin Franzke commented on patch set 8 09/27/24, 07:21

    user-settings-manager.ts:18 Reply

    Done
  19. Benjamin Franzke uploaded patch set 9 09/27/24, 07:23

  20. core-ci voted on patch set 8 V -1 09/27/24, 07:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66709

  21. core-ci voted on patch set 9 V -1 09/27/24, 07:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66710

  22. core-ci voted on patch set 9 V +1 09/27/24, 07:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66710

  23. Andreas Kienast voted on patch set 9 CR +1 V +1 09/27/24, 07:57

  24. Benjamin Kott voted on patch set 9 CR +2 V +2 09/27/24, 08:02

  25. Benjamin Kott merged patch set 10 09/27/24, 08:02