Review main Merged

86347[DOCS] Add descriptions for site settings editor

Garvin Hicking CR +2 V +2 Normal +151 −7 updated 10/14/24, 10:05

Commit message

Document the site settings editor in all system
extension manuals that offer site sets.

* felogin
* fluid_styled_content
* indexed_search
* seo

While system extension EXT:form has a site set, that site set
offers no settings yet and therefore will not appear in the
settings editor.

Screenshots might be provided at a later time.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Lina Wolf +1
    • Simon Praetorius +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Simon Praetorius +1
    • core-ci +1 CI

Issues 1

Files 18

Review log 1114

  1. Garvin Hicking uploaded patch set 1 09/26/24, 10:21

  2. Garvin Hicking commented on patch set 1 09/26/24, 10:21

    Please note, this is based off Linas work in https://review.typo3.org/c/Packages/TYPO3.CMS/+/86040 Screenshots are removed for now.
  3. core-ci voted on patch set 1 V +1 09/26/24, 10:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66661

  4. Guido Schmechel voted on patch set 1 CR +1 V +1 10/03/24, 06:19

  5. Chris Müller commented on patch set 1 CR -1 10/03/24, 07:20

    SettingsEditor.rst:14

    sitemaps -> sites?

    Index.rst:16

    Maybe link "site sets" to the TYPO3 Explained chapter (for users who do not know what it is right now)?

    Index.rst:30

    Maybe link to site sets in TYPO3 Explained for readers who do not know right now what it is?
  6. Garvin Hicking uploaded patch set 2 CR +1 V +1 10/11/24, 09:24

    Address code review
  7. Garvin Hicking commented on patch set 1 10/11/24, 09:24

    Thanks for the feedback, please recheck so we can get it in before 13.4 LTS :-)

    SettingsEditor.rst:14 Reply

    Done

    Index.rst:16 Reply

    Done

    Index.rst:30 Reply

    Done
  8. Garvin Hicking uploaded patch set 3 10/11/24, 09:26

  9. Lina Wolf voted on patch set 3 CR +1 10/11/24, 09:30

  10. core-ci voted on patch set 2 V +1 10/11/24, 09:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67577

  11. core-ci voted on patch set 3 V +1 10/11/24, 09:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67578

  12. Simon Praetorius voted on patch set 3 CR +1 V +1 10/14/24, 09:07

  13. Benjamin Franzke voted on patch set 3 CR +2 V +2 10/14/24, 10:04

  14. Benjamin Franzke merged patch set 4 10/14/24, 10:05