Review main Abandoned

86348[WIP][TASK] Introduce field value manager in FormEngine

Andreas Kienast CR 0 V -1 Hard +431 −14 updated 01/19/26, 08:57

Commit message

This patch aims to introduce a field value manager in FormEngine,
holding state about the initial and updated form fields.

The primary goal is to finally streamline the change detection as is
currently flawed:
If a user updates a field form, the form is marked as changed. If the
user then decides to revert a field to its original value, the field is
still marked as changed.

In the long run, the field value manager allows the introduction of new
features, e.g. saving via AJAX with sending only changed data.

Another pain point is that each FormEngine field requires to have a set
of at least two fields:

  * a human-facing field for changing input
  * a hidden field containing the actual value

FormEngine currently updates any of these fields, depending on the
scenario and needs to update the related fields, which is prone to event
recursions and needs a very careful handling.

Review

  • Code review CR 0
  • Verified V -1
    • core-ci -1 CI

Files 20

Review log 1017

  1. Andreas Kienast uploaded patch set 1 09/26/24, 10:58

  2. core-ci voted on patch set 1 V -1 09/26/24, 11:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66668

  3. Andreas Kienast uploaded patch set 2 V -1 09/26/24, 12:33

  4. core-ci voted on patch set 2 V -1 09/26/24, 12:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66673

  5. Andreas Kienast uploaded patch set 3 V -1 09/26/24, 14:49

  6. core-ci voted on patch set 3 V -1 09/26/24, 14:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66677

  7. Andreas Kienast uploaded patch set 4 V -1 09/27/24, 06:35

  8. core-ci voted on patch set 4 V -1 09/27/24, 06:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66705

  9. Andreas Kienast uploaded patch set 5 V -1 09/27/24, 11:01

  10. core-ci voted on patch set 5 V -1 09/27/24, 11:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66740

  11. Andreas Kienast uploaded patch set 6 V -1 09/28/24, 12:55

  12. core-ci voted on patch set 6 V -1 09/28/24, 13:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66775

  13. Andreas Kienast uploaded patch set 7 V -1 09/28/24, 13:10

  14. core-ci voted on patch set 7 V -1 09/28/24, 13:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66776

  15. Jasmina Ließmann wrote 10/31/24, 09:58

    Removed cc Jasmina Ließmann.
  16. Benni Mack marked it work in progress 03/22/25, 13:09

  17. Andreas Kienast abandoned the change 01/19/26, 08:57