Review main Merged

86352[TASK] Raise "phpstan/phpstan":"^1.12.5"

Anja Leichsenring CR +2 V +2 Easy +8 −8 updated 09/27/24, 06:36

Commit message

PHPStan released a new version phpstan and rephrased a failure description, now the baseline file needs to be adjusted.

Used command(s):

> Build/Scripts/runTests.sh -s composer -- \
  require --dev "phpstan/phpstan":"^1.12."
> Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 79

  1. Anja Leichsenring uploaded patch set 1 09/27/24, 06:19

  2. Benjamin Franzke commented on patch set 1 CR -1 09/27/24, 06:24

    Not true, the error message has only been rephrased by phpstan, it is still the same complaint.
  3. core-ci voted on patch set 1 V +1 09/27/24, 06:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66701

  4. Anja Leichsenring updated the commit message in patch set 2 CR -1 V +1 09/27/24, 06:27

  5. Anja Leichsenring commented on patch set 2 09/27/24, 06:27

    Reply

    Done
  6. Benjamin Franzke voted on patch set 2 CR +1 V +1 09/27/24, 06:30

  7. core-ci voted on patch set 2 V +1 09/27/24, 06:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66703

  8. Andreas Kienast voted on patch set 2 CR +2 V +2 09/27/24, 06:36

  9. Andreas Kienast merged patch set 3 09/27/24, 06:36